diff options
author | David Sterba <dsterba@suse.com> | 2018-08-24 10:13:41 -0400 |
---|---|---|
committer | David Sterba <dsterba@suse.com> | 2019-04-29 13:02:21 -0400 |
commit | 58a2ddaedbf74b8a209426128c130cc9f0dbd11b (patch) | |
tree | 963b3c5e936dfab65624b44d062ddc615ff201a3 /fs/btrfs/locking.c | |
parent | afd495a8264fb25cef49834b5c3559b8aaa612ee (diff) |
btrfs: add assertion helpers for extent buffer read lock counters
The read_locks are a simple counter to track locking balance and used to
assert tree locks. Add helpers to make it conditionally work only in
DEBUG builds. Will be used in followup patches.
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/locking.c')
-rw-r--r-- | fs/btrfs/locking.c | 25 |
1 files changed, 18 insertions, 7 deletions
diff --git a/fs/btrfs/locking.c b/fs/btrfs/locking.c index 47bcd288977d..d3bb19835ab4 100644 --- a/fs/btrfs/locking.c +++ b/fs/btrfs/locking.c | |||
@@ -12,8 +12,6 @@ | |||
12 | #include "extent_io.h" | 12 | #include "extent_io.h" |
13 | #include "locking.h" | 13 | #include "locking.h" |
14 | 14 | ||
15 | static void btrfs_assert_tree_read_locked(struct extent_buffer *eb); | ||
16 | |||
17 | #ifdef CONFIG_BTRFS_DEBUG | 15 | #ifdef CONFIG_BTRFS_DEBUG |
18 | static void btrfs_assert_spinning_writers_get(struct extent_buffer *eb) | 16 | static void btrfs_assert_spinning_writers_get(struct extent_buffer *eb) |
19 | { | 17 | { |
@@ -43,12 +41,30 @@ static void btrfs_assert_spinning_readers_put(struct extent_buffer *eb) | |||
43 | atomic_dec(&eb->spinning_readers); | 41 | atomic_dec(&eb->spinning_readers); |
44 | } | 42 | } |
45 | 43 | ||
44 | static void btrfs_assert_tree_read_locks_get(struct extent_buffer *eb) | ||
45 | { | ||
46 | atomic_inc(&eb->read_locks); | ||
47 | } | ||
48 | |||
49 | static void btrfs_assert_tree_read_locks_put(struct extent_buffer *eb) | ||
50 | { | ||
51 | atomic_dec(&eb->read_locks); | ||
52 | } | ||
53 | |||
54 | static void btrfs_assert_tree_read_locked(struct extent_buffer *eb) | ||
55 | { | ||
56 | BUG_ON(!atomic_read(&eb->read_locks)); | ||
57 | } | ||
58 | |||
46 | #else | 59 | #else |
47 | static void btrfs_assert_spinning_writers_get(struct extent_buffer *eb) { } | 60 | static void btrfs_assert_spinning_writers_get(struct extent_buffer *eb) { } |
48 | static void btrfs_assert_spinning_writers_put(struct extent_buffer *eb) { } | 61 | static void btrfs_assert_spinning_writers_put(struct extent_buffer *eb) { } |
49 | static void btrfs_assert_no_spinning_writers(struct extent_buffer *eb) { } | 62 | static void btrfs_assert_no_spinning_writers(struct extent_buffer *eb) { } |
50 | static void btrfs_assert_spinning_readers_put(struct extent_buffer *eb) { } | 63 | static void btrfs_assert_spinning_readers_put(struct extent_buffer *eb) { } |
51 | static void btrfs_assert_spinning_readers_get(struct extent_buffer *eb) { } | 64 | static void btrfs_assert_spinning_readers_get(struct extent_buffer *eb) { } |
65 | static void btrfs_assert_tree_read_locked(struct extent_buffer *eb) { } | ||
66 | static void btrfs_assert_tree_read_locks_get(struct extent_buffer *eb) { } | ||
67 | static void btrfs_assert_tree_read_locks_put(struct extent_buffer *eb) { } | ||
52 | #endif | 68 | #endif |
53 | 69 | ||
54 | void btrfs_set_lock_blocking_read(struct extent_buffer *eb) | 70 | void btrfs_set_lock_blocking_read(struct extent_buffer *eb) |
@@ -309,8 +325,3 @@ void btrfs_assert_tree_locked(struct extent_buffer *eb) | |||
309 | { | 325 | { |
310 | BUG_ON(!atomic_read(&eb->write_locks)); | 326 | BUG_ON(!atomic_read(&eb->write_locks)); |
311 | } | 327 | } |
312 | |||
313 | static void btrfs_assert_tree_read_locked(struct extent_buffer *eb) | ||
314 | { | ||
315 | BUG_ON(!atomic_read(&eb->read_locks)); | ||
316 | } | ||