btrfs: refactor btrfs_set_prop and add btrfs_set_prop_trans

btrfs_set_prop() takes transaction pointer as the first argument,
however in ioctl.c for the purpose of setting the compression property,
we call btrfs_set_prop() with NULL transaction pointer. Down in
the call chain  btrfs_setxattr() starts transaction to update the
attribute and also to update the inode.

So for clarity, create btrfs_set_prop_trans() with no transaction
pointer as argument, in preparation to start transaction here instead of
doing it down the call chain at btrfs_setxattr().

Also now the btrfs_set_prop() is a static function.

Signed-off-by: Anand Jain <anand.jain@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

1 files changed, 6 insertions, 6 deletions

diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index c1566787a146..4d945b3d88e3 100644
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -284,8 +284,8 @@ static int btrfs_ioctl_setflags(struct file *file, void __user *arg)
                 binode->flags &= ~BTRFS_INODE_COMPRESS;
                 binode->flags |= BTRFS_INODE_NOCOMPRESS;
 
-                ret = btrfs_set_prop(NULL, inode, "btrfs.compression", NULL, 0,
-                                     0);
+                ret = btrfs_set_prop_trans(inode, "btrfs.compression", NULL,
+                                           0, 0);
                 if (ret && ret != -ENODATA)
                         goto out_drop;
         } else if (fsflags & FS_COMPR_FL) {
@@ -303,14 +303,14 @@ static int btrfs_ioctl_setflags(struct file *file, void __user *arg)
                 if (!comp || comp[0] == 0)
                         comp = btrfs_compress_type2str(BTRFS_COMPRESS_ZLIB);
 
-                ret = btrfs_set_prop(NULL, inode, "btrfs.compression", comp,
-                                     strlen(comp), 0);
+                ret = btrfs_set_prop_trans(inode, "btrfs.compression", comp,
+                                           strlen(comp), 0);
                 if (ret)
                         goto out_drop;
 
         } else {
-                ret = btrfs_set_prop(NULL, inode, "btrfs.compression", NULL, 0,
-                                     0);
+                ret = btrfs_set_prop_trans(inode, "btrfs.compression", NULL,
+                                           0, 0);
                 if (ret && ret != -ENODATA)
                         goto out_drop;
                 binode->flags &= ~(BTRFS_INODE_COMPRESS | BTRFS_INODE_NOCOMPRESS);