diff options
author | Nikolay Borisov <nborisov@suse.com> | 2017-10-23 06:51:49 -0400 |
---|---|---|
committer | David Sterba <dsterba@suse.com> | 2018-01-22 10:08:11 -0500 |
commit | 8577787fac828a9873064ccec986f4be6156615d (patch) | |
tree | ea16b9b6075c751cb46d87aa7869494e76df73f1 /fs/btrfs/delayed-inode.c | |
parent | 617c54a88eaba611bfaa917918c773a91c53692a (diff) |
btrfs: Move checks from btrfs_wq_run_delayed_node to btrfs_balance_delayed_items
btrfs_balance_delayed_items is the sole caller of
btrfs_wq_run_delayed_node and already includes one of the checks whether
the delayed inodes should be run. On the other hand
btrfs_wq_run_delayed_node duplicates that check and performs an
additional one for wq congestion.
Let's remove the duplicate check and move the congestion one in
btrfs_balance_delayed_items, leaving btrfs_wq_run_delayed_node to only
care about setting up the wq run. No functional changes.
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/delayed-inode.c')
-rw-r--r-- | fs/btrfs/delayed-inode.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/fs/btrfs/delayed-inode.c b/fs/btrfs/delayed-inode.c index cf0a6a25156c..1c0bab4080a0 100644 --- a/fs/btrfs/delayed-inode.c +++ b/fs/btrfs/delayed-inode.c | |||
@@ -1350,10 +1350,6 @@ static int btrfs_wq_run_delayed_node(struct btrfs_delayed_root *delayed_root, | |||
1350 | { | 1350 | { |
1351 | struct btrfs_async_delayed_work *async_work; | 1351 | struct btrfs_async_delayed_work *async_work; |
1352 | 1352 | ||
1353 | if (atomic_read(&delayed_root->items) < BTRFS_DELAYED_BACKGROUND || | ||
1354 | btrfs_workqueue_normal_congested(fs_info->delayed_workers)) | ||
1355 | return 0; | ||
1356 | |||
1357 | async_work = kmalloc(sizeof(*async_work), GFP_NOFS); | 1353 | async_work = kmalloc(sizeof(*async_work), GFP_NOFS); |
1358 | if (!async_work) | 1354 | if (!async_work) |
1359 | return -ENOMEM; | 1355 | return -ENOMEM; |
@@ -1389,7 +1385,8 @@ void btrfs_balance_delayed_items(struct btrfs_fs_info *fs_info) | |||
1389 | { | 1385 | { |
1390 | struct btrfs_delayed_root *delayed_root = fs_info->delayed_root; | 1386 | struct btrfs_delayed_root *delayed_root = fs_info->delayed_root; |
1391 | 1387 | ||
1392 | if (atomic_read(&delayed_root->items) < BTRFS_DELAYED_BACKGROUND) | 1388 | if ((atomic_read(&delayed_root->items) < BTRFS_DELAYED_BACKGROUND) || |
1389 | btrfs_workqueue_normal_congested(fs_info->delayed_workers)) | ||
1393 | return; | 1390 | return; |
1394 | 1391 | ||
1395 | if (atomic_read(&delayed_root->items) >= BTRFS_DELAYED_WRITEBACK) { | 1392 | if (atomic_read(&delayed_root->items) >= BTRFS_DELAYED_WRITEBACK) { |