summaryrefslogtreecommitdiffstats
path: root/fs/btrfs/compression.c
diff options
context:
space:
mode:
authorNikolay Borisov <nborisov@suse.com>2018-11-27 13:57:58 -0500
committerDavid Sterba <dsterba@suse.com>2018-12-17 08:51:42 -0500
commitda12fe5414f922d896289f037515096f189c66da (patch)
tree09e8347a8723697fd480bd8d44285481d36f06c1 /fs/btrfs/compression.c
parent2ab4fd3135ee21514a50c4f139c4f80c0b43a8ec (diff)
btrfs: Refactor btrfs_merge_bio_hook
This function really checks whether adding more data to the bio will straddle a stripe/chunk. So first let's give it a more appropraite name - btrfs_bio_fits_in_stripe. Secondly, the offset parameter was never used to just remove it. Thirdly, pages are submitted to either btree or data inodes so it's guaranteed that tree->ops is set so replace the check with an ASSERT. Finally, document the parameters of the function. No functional changes. Signed-off-by: Nikolay Borisov <nborisov@suse.com> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/compression.c')
-rw-r--r--fs/btrfs/compression.c7
1 files changed, 4 insertions, 3 deletions
diff --git a/fs/btrfs/compression.c b/fs/btrfs/compression.c
index 34d50bc5c10d..dba59ae914b8 100644
--- a/fs/btrfs/compression.c
+++ b/fs/btrfs/compression.c
@@ -332,7 +332,8 @@ blk_status_t btrfs_submit_compressed_write(struct inode *inode, u64 start,
332 page = compressed_pages[pg_index]; 332 page = compressed_pages[pg_index];
333 page->mapping = inode->i_mapping; 333 page->mapping = inode->i_mapping;
334 if (bio->bi_iter.bi_size) 334 if (bio->bi_iter.bi_size)
335 submit = btrfs_merge_bio_hook(page, 0, PAGE_SIZE, bio, 0); 335 submit = btrfs_bio_fits_in_stripe(page, PAGE_SIZE, bio,
336 0);
336 337
337 page->mapping = NULL; 338 page->mapping = NULL;
338 if (submit || bio_add_page(bio, page, PAGE_SIZE, 0) < 339 if (submit || bio_add_page(bio, page, PAGE_SIZE, 0) <
@@ -610,8 +611,8 @@ blk_status_t btrfs_submit_compressed_read(struct inode *inode, struct bio *bio,
610 page->index = em_start >> PAGE_SHIFT; 611 page->index = em_start >> PAGE_SHIFT;
611 612
612 if (comp_bio->bi_iter.bi_size) 613 if (comp_bio->bi_iter.bi_size)
613 submit = btrfs_merge_bio_hook(page, 0, PAGE_SIZE, 614 submit = btrfs_bio_fits_in_stripe(page, PAGE_SIZE,
614 comp_bio, 0); 615 comp_bio, 0);
615 616
616 page->mapping = NULL; 617 page->mapping = NULL;
617 if (submit || bio_add_page(comp_bio, page, PAGE_SIZE, 0) < 618 if (submit || bio_add_page(comp_bio, page, PAGE_SIZE, 0) <