dm: Refactor for new bio cloning/splitting

We need to convert the dm code to the new bvec_iter primitives which
respect bi_bvec_done; they also allow us to drastically simplify dm's
bio splitting code.

Also, it's no longer necessary to save/restore the bvec array anymore -
driver conversions for immutable bvecs are done, so drivers should never
be modifying it.

Also kill bio_sector_offset(), dm was the only user and it doesn't make
much sense anymore.

Signed-off-by: Kent Overstreet <kmo@daterainc.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Alasdair Kergon <agk@redhat.com>
Cc: dm-devel@redhat.com
Reviewed-by: Mike Snitzer <snitzer@redhat.com>

1 files changed, 0 insertions, 72 deletions

diff --git a/fs/bio.c b/fs/bio.c
index 00dc1893c6ee..6e42b68ab0ac 100644
--- a/fs/bio.c
+++ b/fs/bio.c
@@ -515,40 +515,6 @@ inline int bio_phys_segments(struct request_queue *q, struct bio *bio)
 EXPORT_SYMBOL(bio_phys_segments);
 
 /**
- *      __bio_clone     -       clone a bio
- *      @bio: destination bio
- *      @bio_src: bio to clone
- *
- *      Clone a &bio. Caller will own the returned bio, but not
- *      the actual data it points to. Reference count of returned
- *      bio will be one.
- */
-void __bio_clone(struct bio *bio, struct bio *bio_src)
-{
-        if (bio_is_rw(bio_src)) {
-                struct bio_vec bv;
-                struct bvec_iter iter;
-
-                bio_for_each_segment(bv, bio_src, iter)
-                        bio->bi_io_vec[bio->bi_vcnt++] = bv;
-        } else if (bio_has_data(bio_src)) {
-                memcpy(bio->bi_io_vec, bio_src->bi_io_vec,
-                       bio_src->bi_max_vecs * sizeof(struct bio_vec));
-                bio->bi_vcnt = bio_src->bi_vcnt;
-        }
-
-        /*
-         * most users will be overriding ->bi_bdev with a new target,
-         * so we don't set nor calculate new physical/hw segment counts here
-         */
-        bio->bi_bdev = bio_src->bi_bdev;
-        bio->bi_flags |= 1 << BIO_CLONED;
-        bio->bi_rw = bio_src->bi_rw;
-        bio->bi_iter = bio_src->bi_iter;
-}
-EXPORT_SYMBOL(__bio_clone);
-
-/**
  *      __bio_clone_fast - clone a bio that shares the original bio's biovec
  *      @bio: destination bio
  *      @bio_src: bio to clone
@@ -1921,44 +1887,6 @@ void bio_trim(struct bio *bio, int offset, int size)
 }
 EXPORT_SYMBOL_GPL(bio_trim);
 
-/**
- *      bio_sector_offset - Find hardware sector offset in bio
- *      @bio:           bio to inspect
- *      @index:         bio_vec index
- *      @offset:        offset in bv_page
- *
- *      Return the number of hardware sectors between beginning of bio
- *      and an end point indicated by a bio_vec index and an offset
- *      within that vector's page.
- */
-sector_t bio_sector_offset(struct bio *bio, unsigned short index,
-                           unsigned int offset)
-{
-        unsigned int sector_sz;
-        struct bio_vec *bv;
-        sector_t sectors;
-        int i;
-
-        sector_sz = queue_logical_block_size(bio->bi_bdev->bd_disk->queue);
-        sectors = 0;
-
-        if (index >= bio->bi_iter.bi_idx)
-                index = bio->bi_vcnt - 1;
-
-        bio_for_each_segment_all(bv, bio, i) {
-                if (i == index) {
-                        if (offset > bv->bv_offset)
-                                sectors += (offset - bv->bv_offset) / sector_sz;
-                        break;
-                }
-
-                sectors += bv->bv_len / sector_sz;
-        }
-
-        return sectors;
-}
-EXPORT_SYMBOL(bio_sector_offset);
-
 /*
  * create memory pools for biovec's in a bio_set.
  * use the global biovec slabs created for general use.