diff options
author | Luis de Bethencourt <luisbg@osg.samsung.com> | 2016-07-03 11:29:44 -0400 |
---|---|---|
committer | Luis de Bethencourt <luisbg@osg.samsung.com> | 2016-10-08 05:01:16 -0400 |
commit | 4c3897cce0774b6196f59f98a44eed7e011db5aa (patch) | |
tree | 68c49115da8af4bfc61fbf685cd22be127500596 /fs/befs/datastream.c | |
parent | 9ae51a32b1a060d2db4340d853d989ae622d273f (diff) |
befs: make consistent use of befs_error()
befs_error() is used in potential errors that could happen in befs to
provide informational log messages. befs_debug() is silent when
CONFIG_BEFS_DEBUG=no, and very verbose when switched on, which is why it is
used for general debugging but not for errors.
Fix a few cases where the befs debug utility usage isn't following the
expected pattern. To make sure we have consistent information in the logs.
Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
Diffstat (limited to 'fs/befs/datastream.c')
-rw-r--r-- | fs/befs/datastream.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/fs/befs/datastream.c b/fs/befs/datastream.c index 26cc417cbdce..740fabcd57c0 100644 --- a/fs/befs/datastream.c +++ b/fs/befs/datastream.c | |||
@@ -275,6 +275,8 @@ befs_find_brun_direct(struct super_block *sb, const befs_data_stream *data, | |||
275 | } | 275 | } |
276 | } | 276 | } |
277 | 277 | ||
278 | befs_error(sb, "%s failed to find file block %lu", __func__, | ||
279 | (unsigned long)blockno); | ||
278 | befs_debug(sb, "---> %s ERROR", __func__); | 280 | befs_debug(sb, "---> %s ERROR", __func__); |
279 | return BEFS_ERR; | 281 | return BEFS_ERR; |
280 | } | 282 | } |
@@ -328,9 +330,10 @@ befs_find_brun_indirect(struct super_block *sb, | |||
328 | for (i = 0; i < indirect.len; i++) { | 330 | for (i = 0; i < indirect.len; i++) { |
329 | indirblock = sb_bread(sb, indirblockno + i); | 331 | indirblock = sb_bread(sb, indirblockno + i); |
330 | if (indirblock == NULL) { | 332 | if (indirblock == NULL) { |
331 | befs_debug(sb, "---> %s failed to read " | 333 | befs_error(sb, "---> %s failed to read " |
332 | "disk block %lu from the indirect brun", | 334 | "disk block %lu from the indirect brun", |
333 | __func__, (unsigned long)indirblockno + i); | 335 | __func__, (unsigned long)indirblockno + i); |
336 | befs_debug(sb, "<--- %s ERROR", __func__); | ||
334 | return BEFS_ERR; | 337 | return BEFS_ERR; |
335 | } | 338 | } |
336 | 339 | ||