summaryrefslogtreecommitdiffstats
path: root/fs/affs/namei.c
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2016-06-10 10:51:30 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2016-06-10 23:21:46 -0400
commit8387ff2577eb9ed245df9a39947f66976c6bcd02 (patch)
tree79fafcb5777f16e520d1c39e9389039f866b4c6d /fs/affs/namei.c
parent147d9e7bcad3b8d5465f6eea6292731e7f35dee8 (diff)
vfs: make the string hashes salt the hash
We always mixed in the parent pointer into the dentry name hash, but we did it late at lookup time. It turns out that we can simplify that lookup-time action by salting the hash with the parent pointer early instead of late. A few other users of our string hashes also wanted to mix in their own pointers into the hash, and those are updated to use the same mechanism. Hash users that don't have any particular initial salt can just use the NULL pointer as a no-salt. Cc: Vegard Nossum <vegard.nossum@oracle.com> Cc: George Spelvin <linux@sciencehorizons.net> Cc: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/affs/namei.c')
-rw-r--r--fs/affs/namei.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/fs/affs/namei.c b/fs/affs/namei.c
index 00d3002a6780..eb32029bc776 100644
--- a/fs/affs/namei.c
+++ b/fs/affs/namei.c
@@ -61,7 +61,7 @@ affs_get_toupper(struct super_block *sb)
61 * Note: the dentry argument is the parent dentry. 61 * Note: the dentry argument is the parent dentry.
62 */ 62 */
63static inline int 63static inline int
64__affs_hash_dentry(struct qstr *qstr, toupper_t toupper, bool notruncate) 64__affs_hash_dentry(const struct dentry *dentry, struct qstr *qstr, toupper_t toupper, bool notruncate)
65{ 65{
66 const u8 *name = qstr->name; 66 const u8 *name = qstr->name;
67 unsigned long hash; 67 unsigned long hash;
@@ -72,7 +72,7 @@ __affs_hash_dentry(struct qstr *qstr, toupper_t toupper, bool notruncate)
72 if (retval) 72 if (retval)
73 return retval; 73 return retval;
74 74
75 hash = init_name_hash(); 75 hash = init_name_hash(dentry);
76 len = min(qstr->len, AFFSNAMEMAX); 76 len = min(qstr->len, AFFSNAMEMAX);
77 for (; len > 0; name++, len--) 77 for (; len > 0; name++, len--)
78 hash = partial_name_hash(toupper(*name), hash); 78 hash = partial_name_hash(toupper(*name), hash);
@@ -84,7 +84,7 @@ __affs_hash_dentry(struct qstr *qstr, toupper_t toupper, bool notruncate)
84static int 84static int
85affs_hash_dentry(const struct dentry *dentry, struct qstr *qstr) 85affs_hash_dentry(const struct dentry *dentry, struct qstr *qstr)
86{ 86{
87 return __affs_hash_dentry(qstr, affs_toupper, 87 return __affs_hash_dentry(dentry, qstr, affs_toupper,
88 affs_nofilenametruncate(dentry)); 88 affs_nofilenametruncate(dentry));
89 89
90} 90}
@@ -92,7 +92,7 @@ affs_hash_dentry(const struct dentry *dentry, struct qstr *qstr)
92static int 92static int
93affs_intl_hash_dentry(const struct dentry *dentry, struct qstr *qstr) 93affs_intl_hash_dentry(const struct dentry *dentry, struct qstr *qstr)
94{ 94{
95 return __affs_hash_dentry(qstr, affs_intl_toupper, 95 return __affs_hash_dentry(dentry, qstr, affs_intl_toupper,
96 affs_nofilenametruncate(dentry)); 96 affs_nofilenametruncate(dentry));
97 97
98} 98}