summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorChristoph Hellwig <hch@lst.de>2017-04-05 13:18:12 -0400
committerJens Axboe <axboe@fb.com>2017-04-05 14:05:08 -0400
commit64c7f1d1572cacadfc0a4ca5a937aeffa486de58 (patch)
tree9b6a5030c06ba94e629e1411bebdb01b1735de78 /drivers
parent44e44b29fb99a299dfaa404a59fa35519a197c6b (diff)
block, scsi: move the retries field to struct scsi_request
Instead of bloating the generic struct request with it. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de> Reviewed-by: Sagi Grimberg <sagi@grimberg.me> Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/scsi/osd/osd_initiator.c2
-rw-r--r--drivers/scsi/osst.c2
-rw-r--r--drivers/scsi/scsi_error.c2
-rw-r--r--drivers/scsi/scsi_lib.c4
-rw-r--r--drivers/scsi/sg.c2
-rw-r--r--drivers/scsi/st.c2
-rw-r--r--drivers/target/target_core_pscsi.c2
7 files changed, 8 insertions, 8 deletions
diff --git a/drivers/scsi/osd/osd_initiator.c b/drivers/scsi/osd/osd_initiator.c
index 6903f03c88af..9d0727b2bdec 100644
--- a/drivers/scsi/osd/osd_initiator.c
+++ b/drivers/scsi/osd/osd_initiator.c
@@ -1602,7 +1602,7 @@ static int _init_blk_request(struct osd_request *or,
1602 req->rq_flags |= RQF_QUIET; 1602 req->rq_flags |= RQF_QUIET;
1603 1603
1604 req->timeout = or->timeout; 1604 req->timeout = or->timeout;
1605 req->retries = or->retries; 1605 scsi_req(req)->retries = or->retries;
1606 1606
1607 if (has_out) { 1607 if (has_out) {
1608 or->out.req = req; 1608 or->out.req = req;
diff --git a/drivers/scsi/osst.c b/drivers/scsi/osst.c
index c47f4b349bac..41bc1d64bf86 100644
--- a/drivers/scsi/osst.c
+++ b/drivers/scsi/osst.c
@@ -414,7 +414,7 @@ static int osst_execute(struct osst_request *SRpnt, const unsigned char *cmd,
414 memset(rq->cmd, 0, BLK_MAX_CDB); /* ATAPI hates garbage after CDB */ 414 memset(rq->cmd, 0, BLK_MAX_CDB); /* ATAPI hates garbage after CDB */
415 memcpy(rq->cmd, cmd, rq->cmd_len); 415 memcpy(rq->cmd, cmd, rq->cmd_len);
416 req->timeout = timeout; 416 req->timeout = timeout;
417 req->retries = retries; 417 rq->retries = retries;
418 req->end_io_data = SRpnt; 418 req->end_io_data = SRpnt;
419 419
420 blk_execute_rq_nowait(req->q, NULL, req, 1, osst_end_async); 420 blk_execute_rq_nowait(req->q, NULL, req, 1, osst_end_async);
diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
index f2cafae150bc..2db412dd4b44 100644
--- a/drivers/scsi/scsi_error.c
+++ b/drivers/scsi/scsi_error.c
@@ -1988,7 +1988,7 @@ static void scsi_eh_lock_door(struct scsi_device *sdev)
1988 1988
1989 req->rq_flags |= RQF_QUIET; 1989 req->rq_flags |= RQF_QUIET;
1990 req->timeout = 10 * HZ; 1990 req->timeout = 10 * HZ;
1991 req->retries = 5; 1991 rq->retries = 5;
1992 1992
1993 blk_execute_rq_nowait(req->q, NULL, req, 1, eh_lock_door_done); 1993 blk_execute_rq_nowait(req->q, NULL, req, 1, eh_lock_door_done);
1994} 1994}
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index c1519660824b..11972d1075f1 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -256,7 +256,7 @@ int scsi_execute(struct scsi_device *sdev, const unsigned char *cmd,
256 256
257 rq->cmd_len = COMMAND_SIZE(cmd[0]); 257 rq->cmd_len = COMMAND_SIZE(cmd[0]);
258 memcpy(rq->cmd, cmd, rq->cmd_len); 258 memcpy(rq->cmd, cmd, rq->cmd_len);
259 req->retries = retries; 259 rq->retries = retries;
260 req->timeout = timeout; 260 req->timeout = timeout;
261 req->cmd_flags |= flags; 261 req->cmd_flags |= flags;
262 req->rq_flags |= rq_flags | RQF_QUIET | RQF_PREEMPT; 262 req->rq_flags |= rq_flags | RQF_QUIET | RQF_PREEMPT;
@@ -1177,7 +1177,7 @@ static int scsi_setup_scsi_cmnd(struct scsi_device *sdev, struct request *req)
1177 cmd->cmd_len = scsi_req(req)->cmd_len; 1177 cmd->cmd_len = scsi_req(req)->cmd_len;
1178 cmd->cmnd = scsi_req(req)->cmd; 1178 cmd->cmnd = scsi_req(req)->cmd;
1179 cmd->transfersize = blk_rq_bytes(req); 1179 cmd->transfersize = blk_rq_bytes(req);
1180 cmd->allowed = req->retries; 1180 cmd->allowed = scsi_req(req)->retries;
1181 return BLKPREP_OK; 1181 return BLKPREP_OK;
1182} 1182}
1183 1183
diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
index 29b86505f796..b61cc3c512d3 100644
--- a/drivers/scsi/sg.c
+++ b/drivers/scsi/sg.c
@@ -1716,7 +1716,7 @@ sg_start_req(Sg_request *srp, unsigned char *cmd)
1716 1716
1717 srp->rq = rq; 1717 srp->rq = rq;
1718 rq->end_io_data = srp; 1718 rq->end_io_data = srp;
1719 rq->retries = SG_DEFAULT_RETRIES; 1719 req->retries = SG_DEFAULT_RETRIES;
1720 1720
1721 if ((dxfer_len <= 0) || (dxfer_dir == SG_DXFER_NONE)) 1721 if ((dxfer_len <= 0) || (dxfer_dir == SG_DXFER_NONE))
1722 return 0; 1722 return 0;
diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c
index e5ef78a6848e..5408643431bb 100644
--- a/drivers/scsi/st.c
+++ b/drivers/scsi/st.c
@@ -579,7 +579,7 @@ static int st_scsi_execute(struct st_request *SRpnt, const unsigned char *cmd,
579 memset(rq->cmd, 0, BLK_MAX_CDB); 579 memset(rq->cmd, 0, BLK_MAX_CDB);
580 memcpy(rq->cmd, cmd, rq->cmd_len); 580 memcpy(rq->cmd, cmd, rq->cmd_len);
581 req->timeout = timeout; 581 req->timeout = timeout;
582 req->retries = retries; 582 rq->retries = retries;
583 req->end_io_data = SRpnt; 583 req->end_io_data = SRpnt;
584 584
585 blk_execute_rq_nowait(req->q, NULL, req, 1, st_scsi_execute_end); 585 blk_execute_rq_nowait(req->q, NULL, req, 1, st_scsi_execute_end);
diff --git a/drivers/target/target_core_pscsi.c b/drivers/target/target_core_pscsi.c
index 94cda7991e80..c7fa372c527a 100644
--- a/drivers/target/target_core_pscsi.c
+++ b/drivers/target/target_core_pscsi.c
@@ -1008,7 +1008,7 @@ pscsi_execute_cmd(struct se_cmd *cmd)
1008 req->timeout = PS_TIMEOUT_DISK; 1008 req->timeout = PS_TIMEOUT_DISK;
1009 else 1009 else
1010 req->timeout = PS_TIMEOUT_OTHER; 1010 req->timeout = PS_TIMEOUT_OTHER;
1011 req->retries = PS_RETRY; 1011 scsi_req(req)->retries = PS_RETRY;
1012 1012
1013 blk_execute_rq_nowait(pdv->pdv_sd->request_queue, NULL, req, 1013 blk_execute_rq_nowait(pdv->pdv_sd->request_queue, NULL, req,
1014 (cmd->sam_task_attr == TCM_HEAD_TAG), 1014 (cmd->sam_task_attr == TCM_HEAD_TAG),