summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorTomi Valkeinen <tomi.valkeinen@ti.com>2011-03-02 05:47:54 -0500
committerTomi Valkeinen <tomi.valkeinen@ti.com>2011-03-11 08:46:28 -0500
commit587b5e8269fab583e4e9d2d6bbdc77b289ac78a7 (patch)
treefa322cec486f29d4f31a38e31c2f6bfc82370f1b /drivers
parent277b2881c3c0d97e214487fbd677b0590fb4acf3 (diff)
OMAP: DSS2: Move DPI & SDI init into DSS plat driver
DPI and SDI are different from the other interfaces as they are not hwmods and there is not platform driver for them. They could be said to be a part of DSS or DISPC modules, although it's not a clear definition. This patch moves DPI and SDI initialization into DSS platform driver, making the code more consistent: omap_dss_probe() only initializes platform drivers now. Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/video/omap2/dss/core.c19
-rw-r--r--drivers/video/omap2/dss/dss.c17
2 files changed, 16 insertions, 20 deletions
diff --git a/drivers/video/omap2/dss/core.c b/drivers/video/omap2/dss/core.c
index acefe50209fc..8cfedae98211 100644
--- a/drivers/video/omap2/dss/core.c
+++ b/drivers/video/omap2/dss/core.c
@@ -191,12 +191,6 @@ static int omap_dss_probe(struct platform_device *pdev)
191 goto err_rfbi; 191 goto err_rfbi;
192 } 192 }
193 193
194 r = dpi_init();
195 if (r) {
196 DSSERR("Failed to initialize dpi\n");
197 goto err_dpi;
198 }
199
200 r = dispc_init_platform_driver(); 194 r = dispc_init_platform_driver();
201 if (r) { 195 if (r) {
202 DSSERR("Failed to initialize dispc platform driver\n"); 196 DSSERR("Failed to initialize dispc platform driver\n");
@@ -210,12 +204,6 @@ static int omap_dss_probe(struct platform_device *pdev)
210 } 204 }
211 205
212 if (cpu_is_omap34xx()) { 206 if (cpu_is_omap34xx()) {
213 r = sdi_init();
214 if (r) {
215 DSSERR("Failed to initialize SDI\n");
216 goto err_sdi;
217 }
218
219 r = dsi_init_platform_driver(); 207 r = dsi_init_platform_driver();
220 if (r) { 208 if (r) {
221 DSSERR("Failed to initialize DSI platform driver\n"); 209 DSSERR("Failed to initialize DSI platform driver\n");
@@ -255,15 +243,10 @@ err_debugfs:
255 if (cpu_is_omap34xx()) 243 if (cpu_is_omap34xx())
256 dsi_uninit_platform_driver(); 244 dsi_uninit_platform_driver();
257err_dsi: 245err_dsi:
258 if (cpu_is_omap34xx())
259 sdi_exit();
260err_sdi:
261 venc_uninit_platform_driver(); 246 venc_uninit_platform_driver();
262err_venc: 247err_venc:
263 dispc_uninit_platform_driver(); 248 dispc_uninit_platform_driver();
264err_dispc: 249err_dispc:
265 dpi_exit();
266err_dpi:
267 rfbi_uninit_platform_driver(); 250 rfbi_uninit_platform_driver();
268err_rfbi: 251err_rfbi:
269 dss_uninit_platform_driver(); 252 dss_uninit_platform_driver();
@@ -281,11 +264,9 @@ static int omap_dss_remove(struct platform_device *pdev)
281 264
282 venc_uninit_platform_driver(); 265 venc_uninit_platform_driver();
283 dispc_uninit_platform_driver(); 266 dispc_uninit_platform_driver();
284 dpi_exit();
285 rfbi_uninit_platform_driver(); 267 rfbi_uninit_platform_driver();
286 if (cpu_is_omap34xx()) { 268 if (cpu_is_omap34xx()) {
287 dsi_uninit_platform_driver(); 269 dsi_uninit_platform_driver();
288 sdi_exit();
289 } 270 }
290 271
291 dss_uninit_platform_driver(); 272 dss_uninit_platform_driver();
diff --git a/drivers/video/omap2/dss/dss.c b/drivers/video/omap2/dss/dss.c
index 4025a14c5bc1..e5da050bcf85 100644
--- a/drivers/video/omap2/dss/dss.c
+++ b/drivers/video/omap2/dss/dss.c
@@ -970,9 +970,24 @@ static int omap_dsshw_probe(struct platform_device *pdev)
970 goto err_dss; 970 goto err_dss;
971 } 971 }
972 972
973 r = dpi_init();
974 if (r) {
975 DSSERR("Failed to initialize DPI\n");
976 goto err_dpi;
977 }
978
979 r = sdi_init();
980 if (r) {
981 DSSERR("Failed to initialize SDI\n");
982 goto err_sdi;
983 }
984
973 dss_clk_disable_all_no_ctx(); 985 dss_clk_disable_all_no_ctx();
974 return 0; 986 return 0;
975 987err_sdi:
988 dpi_exit();
989err_dpi:
990 dss_exit();
976err_dss: 991err_dss:
977 dss_clk_disable_all_no_ctx(); 992 dss_clk_disable_all_no_ctx();
978 dss_put_clocks(); 993 dss_put_clocks();