diff options
author | Matan Barak <matanb@mellanox.com> | 2015-05-31 02:30:15 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-05-31 02:35:34 -0400 |
commit | 48564135cba806bd0d6d1704c0ea317318966d9f (patch) | |
tree | 310c9b638b16e17fd0c04e1d7e6ad00efdd7fdab /drivers | |
parent | 9d52bf0a238657ebfddaf5976409ac33174b9f78 (diff) |
net/mlx4_core: Demote simple multicast and broadcast flow steering rules
In SRIOV, when simple (i.e - Ethernet L2 only) flow steering rules are
created, always create them at MLX4_DOMAIN_NIC priority (instead of
the real priority the function created them at). This is done in order
to let multiple functions add broadcast/multicast rules without
affecting other functions, which is necessary for DPDK in SRIOV.
Signed-off-by: Matan Barak <matanb@mellanox.com>
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/infiniband/hw/mlx4/main.c | 4 | ||||
-rw-r--r-- | drivers/net/ethernet/mellanox/mlx4/resource_tracker.c | 23 |
2 files changed, 25 insertions, 2 deletions
diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c index cc64400d41ac..8c96c71e7bab 100644 --- a/drivers/infiniband/hw/mlx4/main.c +++ b/drivers/infiniband/hw/mlx4/main.c | |||
@@ -1090,7 +1090,7 @@ static int __mlx4_ib_create_flow(struct ib_qp *qp, struct ib_flow_attr *flow_att | |||
1090 | 1090 | ||
1091 | ret = mlx4_cmd_imm(mdev->dev, mailbox->dma, reg_id, size >> 2, 0, | 1091 | ret = mlx4_cmd_imm(mdev->dev, mailbox->dma, reg_id, size >> 2, 0, |
1092 | MLX4_QP_FLOW_STEERING_ATTACH, MLX4_CMD_TIME_CLASS_A, | 1092 | MLX4_QP_FLOW_STEERING_ATTACH, MLX4_CMD_TIME_CLASS_A, |
1093 | MLX4_CMD_NATIVE); | 1093 | MLX4_CMD_WRAPPED); |
1094 | if (ret == -ENOMEM) | 1094 | if (ret == -ENOMEM) |
1095 | pr_err("mcg table is full. Fail to register network rule.\n"); | 1095 | pr_err("mcg table is full. Fail to register network rule.\n"); |
1096 | else if (ret == -ENXIO) | 1096 | else if (ret == -ENXIO) |
@@ -1107,7 +1107,7 @@ static int __mlx4_ib_destroy_flow(struct mlx4_dev *dev, u64 reg_id) | |||
1107 | int err; | 1107 | int err; |
1108 | err = mlx4_cmd(dev, reg_id, 0, 0, | 1108 | err = mlx4_cmd(dev, reg_id, 0, 0, |
1109 | MLX4_QP_FLOW_STEERING_DETACH, MLX4_CMD_TIME_CLASS_A, | 1109 | MLX4_QP_FLOW_STEERING_DETACH, MLX4_CMD_TIME_CLASS_A, |
1110 | MLX4_CMD_NATIVE); | 1110 | MLX4_CMD_WRAPPED); |
1111 | if (err) | 1111 | if (err) |
1112 | pr_err("Fail to detach network rule. registration id = 0x%llx\n", | 1112 | pr_err("Fail to detach network rule. registration id = 0x%llx\n", |
1113 | reg_id); | 1113 | reg_id); |
diff --git a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c index 15ec08181658..ab48386bfefc 100644 --- a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c +++ b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c | |||
@@ -3973,6 +3973,22 @@ static int validate_eth_header_mac(int slave, struct _rule_hw *eth_header, | |||
3973 | return 0; | 3973 | return 0; |
3974 | } | 3974 | } |
3975 | 3975 | ||
3976 | static void handle_eth_header_mcast_prio(struct mlx4_net_trans_rule_hw_ctrl *ctrl, | ||
3977 | struct _rule_hw *eth_header) | ||
3978 | { | ||
3979 | if (is_multicast_ether_addr(eth_header->eth.dst_mac) || | ||
3980 | is_broadcast_ether_addr(eth_header->eth.dst_mac)) { | ||
3981 | struct mlx4_net_trans_rule_hw_eth *eth = | ||
3982 | (struct mlx4_net_trans_rule_hw_eth *)eth_header; | ||
3983 | struct _rule_hw *next_rule = (struct _rule_hw *)(eth + 1); | ||
3984 | bool last_rule = next_rule->size == 0 && next_rule->id == 0 && | ||
3985 | next_rule->rsvd == 0; | ||
3986 | |||
3987 | if (last_rule) | ||
3988 | ctrl->prio = cpu_to_be16(MLX4_DOMAIN_NIC); | ||
3989 | } | ||
3990 | } | ||
3991 | |||
3976 | /* | 3992 | /* |
3977 | * In case of missing eth header, append eth header with a MAC address | 3993 | * In case of missing eth header, append eth header with a MAC address |
3978 | * assigned to the VF. | 3994 | * assigned to the VF. |
@@ -4125,6 +4141,12 @@ int mlx4_QP_FLOW_STEERING_ATTACH_wrapper(struct mlx4_dev *dev, int slave, | |||
4125 | rule_header = (struct _rule_hw *)(ctrl + 1); | 4141 | rule_header = (struct _rule_hw *)(ctrl + 1); |
4126 | header_id = map_hw_to_sw_id(be16_to_cpu(rule_header->id)); | 4142 | header_id = map_hw_to_sw_id(be16_to_cpu(rule_header->id)); |
4127 | 4143 | ||
4144 | if (header_id == MLX4_NET_TRANS_RULE_ID_ETH) | ||
4145 | handle_eth_header_mcast_prio(ctrl, rule_header); | ||
4146 | |||
4147 | if (slave == dev->caps.function) | ||
4148 | goto execute; | ||
4149 | |||
4128 | switch (header_id) { | 4150 | switch (header_id) { |
4129 | case MLX4_NET_TRANS_RULE_ID_ETH: | 4151 | case MLX4_NET_TRANS_RULE_ID_ETH: |
4130 | if (validate_eth_header_mac(slave, rule_header, rlist)) { | 4152 | if (validate_eth_header_mac(slave, rule_header, rlist)) { |
@@ -4151,6 +4173,7 @@ int mlx4_QP_FLOW_STEERING_ATTACH_wrapper(struct mlx4_dev *dev, int slave, | |||
4151 | goto err_put; | 4173 | goto err_put; |
4152 | } | 4174 | } |
4153 | 4175 | ||
4176 | execute: | ||
4154 | err = mlx4_cmd_imm(dev, inbox->dma, &vhcr->out_param, | 4177 | err = mlx4_cmd_imm(dev, inbox->dma, &vhcr->out_param, |
4155 | vhcr->in_modifier, 0, | 4178 | vhcr->in_modifier, 0, |
4156 | MLX4_QP_FLOW_STEERING_ATTACH, MLX4_CMD_TIME_CLASS_A, | 4179 | MLX4_QP_FLOW_STEERING_ATTACH, MLX4_CMD_TIME_CLASS_A, |