summaryrefslogtreecommitdiffstats
path: root/drivers/w1
diff options
context:
space:
mode:
authorDavid Fries <David@Fries.net>2014-02-08 14:37:38 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-02-08 16:30:43 -0500
commit7841b647b9c1b118ae4eed33a0af934818e60553 (patch)
tree9227726fe93a49bdbf10d1e226c92d5e408a39aa /drivers/w1
parentd3a8a9dbb903c73a7ec2deae4c9b7d74b6834f4c (diff)
Revert ds1wm.c from "w1: hold bus_mutex in netlink and search"
This reverts ds1wm.c from commit d3a8a9dbb903c73a7ec2deae4c9b7d74b6834f4c. Of the three files changed ds1wm.c ds2490.c and w1_netlink.c, it turns out ds1wm.c was locking bus_mutex, but inside the loop and I missed it. Reverting ds1wm.c to the previous version. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: David Fries <David@Fries.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/w1')
-rw-r--r--drivers/w1/masters/ds1wm.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/w1/masters/ds1wm.c b/drivers/w1/masters/ds1wm.c
index b077b8b42758..02df3b1381d2 100644
--- a/drivers/w1/masters/ds1wm.c
+++ b/drivers/w1/masters/ds1wm.c
@@ -326,14 +326,13 @@ static void ds1wm_search(void *data, struct w1_master *master_dev,
326 unsigned slaves_found = 0; 326 unsigned slaves_found = 0;
327 unsigned int pass = 0; 327 unsigned int pass = 0;
328 328
329 mutex_lock(&master_dev->bus_mutex);
330 dev_dbg(&ds1wm_data->pdev->dev, "search begin\n"); 329 dev_dbg(&ds1wm_data->pdev->dev, "search begin\n");
331 while (true) { 330 while (true) {
332 ++pass; 331 ++pass;
333 if (pass > 100) { 332 if (pass > 100) {
334 dev_dbg(&ds1wm_data->pdev->dev, 333 dev_dbg(&ds1wm_data->pdev->dev,
335 "too many attempts (100), search aborted\n"); 334 "too many attempts (100), search aborted\n");
336 break; 335 return;
337 } 336 }
338 337
339 mutex_lock(&master_dev->bus_mutex); 338 mutex_lock(&master_dev->bus_mutex);
@@ -440,7 +439,6 @@ static void ds1wm_search(void *data, struct w1_master *master_dev,
440 dev_dbg(&ds1wm_data->pdev->dev, 439 dev_dbg(&ds1wm_data->pdev->dev,
441 "pass: %d total: %d search done ms d bit pos: %d\n", pass, 440 "pass: %d total: %d search done ms d bit pos: %d\n", pass,
442 slaves_found, ms_discrep_bit); 441 slaves_found, ms_discrep_bit);
443 mutex_unlock(&master_dev->bus_mutex);
444} 442}
445 443
446/* --------------------------------------------------------------------- */ 444/* --------------------------------------------------------------------- */