diff options
author | Markus Elfring <elfring@users.sourceforge.net> | 2015-02-05 10:33:09 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-03-18 11:56:40 -0400 |
commit | 533726f736c2c32956d78ad6f49ffaada110cbfd (patch) | |
tree | 816a5a24cdf390fe905324d5d70cde4251f349b7 /drivers/usb/atm | |
parent | 28ed20755897b3726f07a0418c3d2fe17b3e5c86 (diff) |
ueagle-atm: Delete unnecessary checks before the function call "release_firmware"
The release_firmware() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/atm')
-rw-r--r-- | drivers/usb/atm/ueagle-atm.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/usb/atm/ueagle-atm.c b/drivers/usb/atm/ueagle-atm.c index 5a459377574b..888998a7fe31 100644 --- a/drivers/usb/atm/ueagle-atm.c +++ b/drivers/usb/atm/ueagle-atm.c | |||
@@ -952,7 +952,7 @@ static void uea_load_page_e1(struct work_struct *work) | |||
952 | int i; | 952 | int i; |
953 | 953 | ||
954 | /* reload firmware when reboot start and it's loaded already */ | 954 | /* reload firmware when reboot start and it's loaded already */ |
955 | if (ovl == 0 && pageno == 0 && sc->dsp_firm) { | 955 | if (ovl == 0 && pageno == 0) { |
956 | release_firmware(sc->dsp_firm); | 956 | release_firmware(sc->dsp_firm); |
957 | sc->dsp_firm = NULL; | 957 | sc->dsp_firm = NULL; |
958 | } | 958 | } |
@@ -1074,7 +1074,7 @@ static void uea_load_page_e4(struct work_struct *work) | |||
1074 | uea_dbg(INS_TO_USBDEV(sc), "sending DSP page %u\n", pageno); | 1074 | uea_dbg(INS_TO_USBDEV(sc), "sending DSP page %u\n", pageno); |
1075 | 1075 | ||
1076 | /* reload firmware when reboot start and it's loaded already */ | 1076 | /* reload firmware when reboot start and it's loaded already */ |
1077 | if (pageno == 0 && sc->dsp_firm) { | 1077 | if (pageno == 0) { |
1078 | release_firmware(sc->dsp_firm); | 1078 | release_firmware(sc->dsp_firm); |
1079 | sc->dsp_firm = NULL; | 1079 | sc->dsp_firm = NULL; |
1080 | } | 1080 | } |