summaryrefslogtreecommitdiffstats
path: root/drivers/tty/cyclades.c
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2017-11-14 00:05:31 -0500
committerLinus Torvalds <torvalds@linux-foundation.org>2017-11-14 00:05:31 -0500
commitfb0255fb2941ef6f21742b2bc146d6b9aef4fedc (patch)
tree8334f3485152b1c887ddfe04ba9a95c8a704481c /drivers/tty/cyclades.c
parent449fcf3ab0baf3dde9952385e6789f2ca10c3980 (diff)
parent57f5d648c45c3d40a3257c06629c14fd53c383bc (diff)
Merge tag 'tty-4.15-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty
Pull tty/serial updates from Greg KH: "Here is the big tty/serial driver pull request for 4.15-rc1. Lots of serial driver updates in here, some small vt cleanups, and a raft of SPDX and license boilerplate cleanups, messing up the diffstat a bit. Nothing major, with no realy functional changes except better hardware support for some platforms. All of these have been in linux-next for a while with no reported issues" * tag 'tty-4.15-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty: (110 commits) tty: ehv_bytechan: fix spelling mistake tty: serial: meson: allow baud-rates lower than 9600 serial: 8250_fintek: Fix crash with baud rate B0 serial: 8250_fintek: Disable delays for ports != 0 serial: 8250_fintek: Return -EINVAL on invalid configuration tty: Remove redundant license text tty: serdev: Remove redundant license text tty: hvc: Remove redundant license text tty: serial: Remove redundant license text tty: add SPDX identifiers to all remaining files in drivers/tty/ tty: serial: jsm: remove redundant pointer ts tty: serial: jsm: add space before the open parenthesis '(' tty: serial: jsm: fix coding style tty: serial: jsm: delete space between function name and '(' tty: serial: jsm: add blank line after declarations tty: serial: jsm: change the type of local variable tty: serial: imx: remove dead code imx_dma_rxint tty: serial: imx: disable ageing timer interrupt if dma in use serial: 8250: fix potential deadlock in rs485-mode serial: m32r_sio: Drop redundant .data assignment ...
Diffstat (limited to 'drivers/tty/cyclades.c')
-rw-r--r--drivers/tty/cyclades.c17
1 files changed, 7 insertions, 10 deletions
diff --git a/drivers/tty/cyclades.c b/drivers/tty/cyclades.c
index dac8a1a8e4ac..5d442469c95e 100644
--- a/drivers/tty/cyclades.c
+++ b/drivers/tty/cyclades.c
@@ -1,3 +1,4 @@
1// SPDX-License-Identifier: GPL-2.0
1#undef BLOCKMOVE 2#undef BLOCKMOVE
2#define Z_WAKE 3#define Z_WAKE
3#undef Z_EXT_CHARS_IN_BUFFER 4#undef Z_EXT_CHARS_IN_BUFFER
@@ -286,8 +287,7 @@ static long cyz_polling_cycle = CZ_DEF_POLL;
286static DEFINE_TIMER(cyz_timerlist, cyz_poll); 287static DEFINE_TIMER(cyz_timerlist, cyz_poll);
287 288
288#else /* CONFIG_CYZ_INTR */ 289#else /* CONFIG_CYZ_INTR */
289static void cyz_rx_restart(unsigned long); 290static void cyz_rx_restart(struct timer_list *);
290static struct timer_list cyz_rx_full_timer[NR_PORTS];
291#endif /* CONFIG_CYZ_INTR */ 291#endif /* CONFIG_CYZ_INTR */
292 292
293static void cyy_writeb(struct cyclades_port *port, u32 reg, u8 val) 293static void cyy_writeb(struct cyclades_port *port, u32 reg, u8 val)
@@ -992,10 +992,8 @@ static void cyz_handle_rx(struct cyclades_port *info)
992 else 992 else
993 char_count = rx_put - rx_get + rx_bufsize; 993 char_count = rx_put - rx_get + rx_bufsize;
994 if (char_count >= readl(&buf_ctrl->rx_threshold) && 994 if (char_count >= readl(&buf_ctrl->rx_threshold) &&
995 !timer_pending(&cyz_rx_full_timer[ 995 !timer_pending(&info->rx_full_timer))
996 info->line])) 996 mod_timer(&info->rx_full_timer, jiffies + 1);
997 mod_timer(&cyz_rx_full_timer[info->line],
998 jiffies + 1);
999#endif 997#endif
1000 info->idle_stats.recv_idle = jiffies; 998 info->idle_stats.recv_idle = jiffies;
1001 tty_schedule_flip(&info->port); 999 tty_schedule_flip(&info->port);
@@ -1197,9 +1195,9 @@ static irqreturn_t cyz_interrupt(int irq, void *dev_id)
1197 return IRQ_HANDLED; 1195 return IRQ_HANDLED;
1198} /* cyz_interrupt */ 1196} /* cyz_interrupt */
1199 1197
1200static void cyz_rx_restart(unsigned long arg) 1198static void cyz_rx_restart(struct timer_list *t)
1201{ 1199{
1202 struct cyclades_port *info = (struct cyclades_port *)arg; 1200 struct cyclades_port *info = from_timer(info, t, rx_full_timer);
1203 struct cyclades_card *card = info->card; 1201 struct cyclades_card *card = info->card;
1204 int retval; 1202 int retval;
1205 __u32 channel = info->line - card->first_line; 1203 __u32 channel = info->line - card->first_line;
@@ -3097,8 +3095,7 @@ static int cy_init_card(struct cyclades_card *cinfo)
3097 else 3095 else
3098 info->xmit_fifo_size = 4 * CYZ_FIFO_SIZE; 3096 info->xmit_fifo_size = 4 * CYZ_FIFO_SIZE;
3099#ifdef CONFIG_CYZ_INTR 3097#ifdef CONFIG_CYZ_INTR
3100 setup_timer(&cyz_rx_full_timer[port], 3098 timer_setup(&info->rx_full_timer, cyz_rx_restart, 0);
3101 cyz_rx_restart, (unsigned long)info);
3102#endif 3099#endif
3103 } else { 3100 } else {
3104 unsigned short chip_number; 3101 unsigned short chip_number;