scsi: target: replace fabric_ops.name with fabric_alias

iscsi_target_mod is the only LIO fabric where fabric_ops.name differs from
the fabric_ops.fabric_name string.  fabric_ops.name is used when matching
target/$fabric ConfigFS create paths, so rename it .fabric_alias and
fallback to target/$fabric vs .fabric_name comparison if .fabric_alias
isn't initialised.  iscsi_target_mod is the only fabric module to set
.fabric_alias . All other fabric modules rely on .fabric_name matching and
can drop the duplicate string.

Signed-off-by: David Disseldorp <ddiss@suse.de>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

5 files changed, 19 insertions, 16 deletions

diff --git a/drivers/target/iscsi/iscsi_target_configfs.c b/drivers/target/iscsi/iscsi_target_configfs.c
index 5c9e98ee42de..39a700a41f6e 100644
--- a/drivers/target/iscsi/iscsi_target_configfs.c
+++ b/drivers/target/iscsi/iscsi_target_configfs.c
@@ -1544,7 +1544,7 @@ static void lio_release_cmd(struct se_cmd *se_cmd)
 
 const struct target_core_fabric_ops iscsi_ops = {
         .module                         = THIS_MODULE,
-        .name                           = "iscsi",
+        .fabric_alias                   = "iscsi",
         .fabric_name                    = "iSCSI",
         .node_acl_size                  = sizeof(struct iscsi_node_acl),
         .tpg_get_wwn                    = lio_tpg_get_endpoint_wwn,
diff --git a/drivers/target/loopback/tcm_loop.c b/drivers/target/loopback/tcm_loop.c
index 962845224c19..b0991e86587f 100644
--- a/drivers/target/loopback/tcm_loop.c
+++ b/drivers/target/loopback/tcm_loop.c
@@ -1144,7 +1144,6 @@ static struct configfs_attribute *tcm_loop_wwn_attrs[] = {
 
 static const struct target_core_fabric_ops loop_ops = {
         .module                         = THIS_MODULE,
-        .name                           = "loopback",
         .fabric_name                    = "loopback",
         .tpg_get_wwn                    = tcm_loop_get_endpoint_wwn,
         .tpg_get_tag                    = tcm_loop_get_tag,
diff --git a/drivers/target/sbp/sbp_target.c b/drivers/target/sbp/sbp_target.c
index f5830bb4ef5a..08cee13dfb9a 100644
--- a/drivers/target/sbp/sbp_target.c
+++ b/drivers/target/sbp/sbp_target.c
@@ -2318,7 +2318,6 @@ static struct configfs_attribute *sbp_tpg_attrib_attrs[] = {
 
 static const struct target_core_fabric_ops sbp_ops = {
         .module                         = THIS_MODULE,
-        .name                           = "sbp",
         .fabric_name                    = "sbp",
         .tpg_get_wwn                    = sbp_get_fabric_wwn,
         .tpg_get_tag                    = sbp_get_tag,
diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
index ae6c44c48f75..0e8449be5115 100644
--- a/drivers/target/target_core_configfs.c
+++ b/drivers/target/target_core_configfs.c
@@ -172,7 +172,10 @@ static struct target_fabric_configfs *target_core_get_fabric(
 
         mutex_lock(&g_tf_lock);
         list_for_each_entry(tf, &g_tf_list, tf_list) {
-                if (!strcmp(tf->tf_ops->name, name)) {
+                const char *cmp_name = tf->tf_ops->fabric_alias;
+                if (!cmp_name)
+                        cmp_name = tf->tf_ops->fabric_name;
+                if (!strcmp(cmp_name, name)) {
                         atomic_inc(&tf->tf_access_cnt);
                         mutex_unlock(&g_tf_lock);
                         return tf;
@@ -249,7 +252,7 @@ static struct config_group *target_core_register_fabric(
                 return ERR_PTR(-EINVAL);
         }
         pr_debug("Target_Core_ConfigFS: REGISTER -> Located fabric:"
-                        " %s\n", tf->tf_ops->name);
+                        " %s\n", tf->tf_ops->fabric_name);
         /*
          * On a successful target_core_get_fabric() look, the returned
          * struct target_fabric_configfs *tf will contain a usage reference.
@@ -282,7 +285,7 @@ static void target_core_deregister_fabric(
                 " tf list\n", config_item_name(item));
 
         pr_debug("Target_Core_ConfigFS: DEREGISTER -> located fabric:"
-                        " %s\n", tf->tf_ops->name);
+                        " %s\n", tf->tf_ops->fabric_name);
         atomic_dec(&tf->tf_access_cnt);
 
         pr_debug("Target_Core_ConfigFS: DEREGISTER -> Releasing ci"
@@ -342,19 +345,22 @@ EXPORT_SYMBOL(target_undepend_item);
 
 static int target_fabric_tf_ops_check(const struct target_core_fabric_ops *tfo)
 {
-        if (!tfo->name) {
-                pr_err("Missing tfo->name\n");
-                return -EINVAL;
-        }
-        if (strlen(tfo->name) >= TARGET_FABRIC_NAME_SIZE) {
-                pr_err("Passed name: %s exceeds TARGET_FABRIC"
-                        "_NAME_SIZE\n", tfo->name);
-                return -EINVAL;
+        if (tfo->fabric_alias) {
+                if (strlen(tfo->fabric_alias) >= TARGET_FABRIC_NAME_SIZE) {
+                        pr_err("Passed alias: %s exceeds "
+                                "TARGET_FABRIC_NAME_SIZE\n", tfo->fabric_alias);
+                        return -EINVAL;
+                }
         }
         if (!tfo->fabric_name) {
                 pr_err("Missing tfo->fabric_name\n");
                 return -EINVAL;
         }
+        if (strlen(tfo->fabric_name) >= TARGET_FABRIC_NAME_SIZE) {
+                pr_err("Passed name: %s exceeds "
+                        "TARGET_FABRIC_NAME_SIZE\n", tfo->fabric_name);
+                return -EINVAL;
+        }
         if (!tfo->tpg_get_wwn) {
                 pr_err("Missing tfo->tpg_get_wwn()\n");
                 return -EINVAL;
@@ -486,7 +492,7 @@ void target_unregister_template(const struct target_core_fabric_ops *fo)
 
         mutex_lock(&g_tf_lock);
         list_for_each_entry(t, &g_tf_list, tf_list) {
-                if (!strcmp(t->tf_ops->name, fo->name)) {
+                if (!strcmp(t->tf_ops->fabric_name, fo->fabric_name)) {
                         BUG_ON(atomic_read(&t->tf_access_cnt));
                         list_del(&t->tf_list);
                         mutex_unlock(&g_tf_lock);
diff --git a/drivers/target/tcm_fc/tfc_conf.c b/drivers/target/tcm_fc/tfc_conf.c
index 8b884246a9be..1ce49518d440 100644
--- a/drivers/target/tcm_fc/tfc_conf.c
+++ b/drivers/target/tcm_fc/tfc_conf.c
@@ -422,7 +422,6 @@ static u32 ft_tpg_get_inst_index(struct se_portal_group *se_tpg)
 
 static const struct target_core_fabric_ops ft_fabric_ops = {
         .module =                       THIS_MODULE,
-        .name =                         "fc",
         .fabric_name =                  "fc",
         .node_acl_size =                sizeof(struct ft_node_acl),
         .tpg_get_wwn =                  ft_get_fabric_wwn,