diff options
author | Johannes Thumshirn <jthumshirn@suse.de> | 2018-06-25 07:20:58 -0400 |
---|---|---|
committer | Martin K. Petersen <martin.petersen@oracle.com> | 2018-06-26 12:27:06 -0400 |
commit | c65be1a63f1df224c8f22d72b9ec824241ada585 (patch) | |
tree | 92d2f1e475f5556095f02b172cd7b7ac595e6479 /drivers/scsi/scsi.c | |
parent | 8e1695a07c7b28e2eb1c02cc01e2b8f5dd28bf87 (diff) |
scsi: core: check for equality of result byte values
When evaluating a SCSI command's result using the field access macros,
check for equality of the fields and not if a specific bit is set.
This is a preparation patch, for reworking the results field in the
SCSI command.
Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bart Van Assche <bart.vanassche@wdc.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/scsi.c')
-rw-r--r-- | drivers/scsi/scsi.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c index 4c60c260c5da..70ef3c39061d 100644 --- a/drivers/scsi/scsi.c +++ b/drivers/scsi/scsi.c | |||
@@ -162,7 +162,7 @@ void scsi_log_completion(struct scsi_cmnd *cmd, int disposition) | |||
162 | (level > 1)) { | 162 | (level > 1)) { |
163 | scsi_print_result(cmd, "Done", disposition); | 163 | scsi_print_result(cmd, "Done", disposition); |
164 | scsi_print_command(cmd); | 164 | scsi_print_command(cmd); |
165 | if (status_byte(cmd->result) & CHECK_CONDITION) | 165 | if (status_byte(cmd->result) == CHECK_CONDITION) |
166 | scsi_print_sense(cmd); | 166 | scsi_print_sense(cmd); |
167 | if (level > 3) | 167 | if (level > 3) |
168 | scmd_printk(KERN_INFO, cmd, | 168 | scmd_printk(KERN_INFO, cmd, |