diff options
author | Colin Ian King <colin.king@canonical.com> | 2018-02-06 09:34:10 -0500 |
---|---|---|
committer | Martin K. Petersen <martin.petersen@oracle.com> | 2018-02-13 21:37:06 -0500 |
commit | b22ee87d84296233886139654e8a125d8f79b44e (patch) | |
tree | 8f2f5544a34805662ac4baf42a947cc242b2bf59 /drivers/scsi/pmcraid.c | |
parent | 2976fbb6a7aff04076d13d2a37e4b8dbe0d6fd4c (diff) |
scsi: pmcraid: remove redundant initializations of pointer 'ioadl'
There are several occurrances where pointer ioadl is initialized with a
value that is never read and where it is re-assigned a new value later
on, hence the initialization is redundant and can be removed.
Cleans up clang warnings:
drivers/scsi/pmcraid.c:1028:29: warning: Value stored to 'ioadl' during
its initialization is never read
drivers/scsi/pmcraid.c:3178:29: warning: Value stored to 'ioadl' during
its initialization is never read
drivers/scsi/pmcraid.c:5495:29: warning: Value stored to 'ioadl' during
its initialization is never read
drivers/scsi/pmcraid.c:5668:29: warning: Value stored to 'ioadl' during
its initialization is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/pmcraid.c')
-rw-r--r-- | drivers/scsi/pmcraid.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c index 201c8de1853d..9330cc5ba34d 100644 --- a/drivers/scsi/pmcraid.c +++ b/drivers/scsi/pmcraid.c | |||
@@ -1025,7 +1025,7 @@ static void pmcraid_get_fwversion_done(struct pmcraid_cmd *cmd) | |||
1025 | static void pmcraid_get_fwversion(struct pmcraid_cmd *cmd) | 1025 | static void pmcraid_get_fwversion(struct pmcraid_cmd *cmd) |
1026 | { | 1026 | { |
1027 | struct pmcraid_ioarcb *ioarcb = &cmd->ioa_cb->ioarcb; | 1027 | struct pmcraid_ioarcb *ioarcb = &cmd->ioa_cb->ioarcb; |
1028 | struct pmcraid_ioadl_desc *ioadl = ioarcb->add_data.u.ioadl; | 1028 | struct pmcraid_ioadl_desc *ioadl; |
1029 | struct pmcraid_instance *pinstance = cmd->drv_inst; | 1029 | struct pmcraid_instance *pinstance = cmd->drv_inst; |
1030 | u16 data_size = sizeof(struct pmcraid_inquiry_data); | 1030 | u16 data_size = sizeof(struct pmcraid_inquiry_data); |
1031 | 1031 | ||
@@ -3175,7 +3175,7 @@ static int pmcraid_build_ioadl( | |||
3175 | 3175 | ||
3176 | struct scsi_cmnd *scsi_cmd = cmd->scsi_cmd; | 3176 | struct scsi_cmnd *scsi_cmd = cmd->scsi_cmd; |
3177 | struct pmcraid_ioarcb *ioarcb = &(cmd->ioa_cb->ioarcb); | 3177 | struct pmcraid_ioarcb *ioarcb = &(cmd->ioa_cb->ioarcb); |
3178 | struct pmcraid_ioadl_desc *ioadl = ioarcb->add_data.u.ioadl; | 3178 | struct pmcraid_ioadl_desc *ioadl; |
3179 | 3179 | ||
3180 | u32 length = scsi_bufflen(scsi_cmd); | 3180 | u32 length = scsi_bufflen(scsi_cmd); |
3181 | 3181 | ||
@@ -5492,7 +5492,7 @@ static void pmcraid_set_timestamp(struct pmcraid_cmd *cmd) | |||
5492 | struct pmcraid_instance *pinstance = cmd->drv_inst; | 5492 | struct pmcraid_instance *pinstance = cmd->drv_inst; |
5493 | struct pmcraid_ioarcb *ioarcb = &cmd->ioa_cb->ioarcb; | 5493 | struct pmcraid_ioarcb *ioarcb = &cmd->ioa_cb->ioarcb; |
5494 | __be32 time_stamp_len = cpu_to_be32(PMCRAID_TIMESTAMP_LEN); | 5494 | __be32 time_stamp_len = cpu_to_be32(PMCRAID_TIMESTAMP_LEN); |
5495 | struct pmcraid_ioadl_desc *ioadl = ioarcb->add_data.u.ioadl; | 5495 | struct pmcraid_ioadl_desc *ioadl; |
5496 | u64 timestamp; | 5496 | u64 timestamp; |
5497 | 5497 | ||
5498 | timestamp = ktime_get_real_seconds() * 1000; | 5498 | timestamp = ktime_get_real_seconds() * 1000; |
@@ -5665,7 +5665,7 @@ static void pmcraid_init_res_table(struct pmcraid_cmd *cmd) | |||
5665 | static void pmcraid_querycfg(struct pmcraid_cmd *cmd) | 5665 | static void pmcraid_querycfg(struct pmcraid_cmd *cmd) |
5666 | { | 5666 | { |
5667 | struct pmcraid_ioarcb *ioarcb = &cmd->ioa_cb->ioarcb; | 5667 | struct pmcraid_ioarcb *ioarcb = &cmd->ioa_cb->ioarcb; |
5668 | struct pmcraid_ioadl_desc *ioadl = ioarcb->add_data.u.ioadl; | 5668 | struct pmcraid_ioadl_desc *ioadl; |
5669 | struct pmcraid_instance *pinstance = cmd->drv_inst; | 5669 | struct pmcraid_instance *pinstance = cmd->drv_inst; |
5670 | __be32 cfg_table_size = cpu_to_be32(sizeof(struct pmcraid_config_table)); | 5670 | __be32 cfg_table_size = cpu_to_be32(sizeof(struct pmcraid_config_table)); |
5671 | 5671 | ||