summaryrefslogtreecommitdiffstats
path: root/drivers/scsi/mpt3sas
diff options
context:
space:
mode:
authorSreekanth Reddy <sreekanth.reddy@avagotech.com>2015-01-12 01:08:57 -0500
committerChristoph Hellwig <hch@lst.de>2015-01-13 10:27:24 -0500
commitddb588bebeab4606c8b14f952bfd16f2f8864dda (patch)
tree2eec211cfea408ec52b83cad595219da214a209a /drivers/scsi/mpt3sas
parent2d8ce8c9d4b25b88eb4aa6bc52492eb7e0ae1dab (diff)
mpt2sas, mpt3sas: Fail the host reset initiated due to discovery related I/O timeouts at driver load time
When a flaky disk is there in a topology then during driver load, discovery related I/O times out; which results in SCSI error recovery initiating host reset and then the controller won't see any disk. In this patch, The driver would return FAILED status to the host reset initiated due to discovery related I/O timeout if ioc->is_driver_loading is set. This flag would be set until we exit out of scsih_scan_finished(). i.e. During device discovery if one of the disk is flaky (which responds to some discovery commands and doesn't respond to some) the driver wouldn't perform host reset for discovery related I/O timeout. Instead it would return Failure for the host reset resulting in the flaky disk getting removed by the SCSI Mid layer, so other disks would be added correctly. Signed-off-by: Sreekanth Reddy <Sreekanth.Reddy@avagotech.com> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/scsi/mpt3sas')
-rw-r--r--drivers/scsi/mpt3sas/mpt3sas_scsih.c8
1 files changed, 8 insertions, 0 deletions
diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
index c3c0b45df102..5aa2ee96d0e6 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
@@ -2392,9 +2392,17 @@ _scsih_host_reset(struct scsi_cmnd *scmd)
2392 ioc->name, scmd); 2392 ioc->name, scmd);
2393 scsi_print_command(scmd); 2393 scsi_print_command(scmd);
2394 2394
2395 if (ioc->is_driver_loading) {
2396 pr_info(MPT3SAS_FMT "Blocking the host reset\n",
2397 ioc->name);
2398 r = FAILED;
2399 goto out;
2400 }
2401
2395 retval = mpt3sas_base_hard_reset_handler(ioc, CAN_SLEEP, 2402 retval = mpt3sas_base_hard_reset_handler(ioc, CAN_SLEEP,
2396 FORCE_BIG_HAMMER); 2403 FORCE_BIG_HAMMER);
2397 r = (retval < 0) ? FAILED : SUCCESS; 2404 r = (retval < 0) ? FAILED : SUCCESS;
2405out:
2398 pr_info(MPT3SAS_FMT "host reset: %s scmd(%p)\n", 2406 pr_info(MPT3SAS_FMT "host reset: %s scmd(%p)\n",
2399 ioc->name, ((r == SUCCESS) ? "SUCCESS" : "FAILED"), scmd); 2407 ioc->name, ((r == SUCCESS) ? "SUCCESS" : "FAILED"), scmd);
2400 2408