summaryrefslogtreecommitdiffstats
path: root/drivers/scsi/NCR5380.h
diff options
context:
space:
mode:
authorFinn Thain <fthain@telegraphics.com.au>2016-10-10 00:46:52 -0400
committerMartin K. Petersen <martin.petersen@oracle.com>2016-11-08 17:29:47 -0500
commitd4408dd7ecff6ed3561f155923738474c585f31d (patch)
treed5b2e08ec4d80487519d6016ad329ae551b52dd5 /drivers/scsi/NCR5380.h
parentabd12b09292cc87a75f7c3e3c3f2b12589560bb1 (diff)
scsi: ncr5380: Simplify register polling limit
When polling a device register under irq lock the polling loop terminates after a given number of jiffies. Make this timeout independent of the HZ setting. All 5380 drivers benefit from this patch, which optimizes the PIO fast path, because they all use PIO transfers (for phases other than DATA IN and DATA OUT). Some cards support only PIO transfers (even for DATA phases). CPU cycles are scarce on some of these systems, so a small improvement here makes a big difference. Signed-off-by: Finn Thain <fthain@telegraphics.com.au> Reviewed-by: Hannes Reinecke <hare@suse.com> Tested-by: Ondrej Zary <linux@rainbow-software.org> Tested-by: Michael Schmitz <schmitzmic@gmail.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/NCR5380.h')
-rw-r--r--drivers/scsi/NCR5380.h5
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/scsi/NCR5380.h b/drivers/scsi/NCR5380.h
index 965d92339455..cbb29d604fe0 100644
--- a/drivers/scsi/NCR5380.h
+++ b/drivers/scsi/NCR5380.h
@@ -239,7 +239,7 @@ struct NCR5380_hostdata {
239 * transfer to handle chip overruns */ 239 * transfer to handle chip overruns */
240 struct work_struct main_task; 240 struct work_struct main_task;
241 struct workqueue_struct *work_q; 241 struct workqueue_struct *work_q;
242 unsigned long accesses_per_ms; /* chip register accesses per ms */ 242 unsigned long poll_loops; /* register polling limit */
243}; 243};
244 244
245#ifdef __KERNEL__ 245#ifdef __KERNEL__
@@ -252,6 +252,9 @@ struct NCR5380_cmd {
252 252
253#define NCR5380_PIO_CHUNK_SIZE 256 253#define NCR5380_PIO_CHUNK_SIZE 256
254 254
255/* Time limit (ms) to poll registers when IRQs are disabled, e.g. during PDMA */
256#define NCR5380_REG_POLL_TIME 10
257
255static inline struct scsi_cmnd *NCR5380_to_scmd(struct NCR5380_cmd *ncmd_ptr) 258static inline struct scsi_cmnd *NCR5380_to_scmd(struct NCR5380_cmd *ncmd_ptr)
256{ 259{
257 return ((struct scsi_cmnd *)ncmd_ptr) - 1; 260 return ((struct scsi_cmnd *)ncmd_ptr) - 1;