summaryrefslogtreecommitdiffstats
path: root/drivers/rtc/rtc-ds1742.c
diff options
context:
space:
mode:
authorVladimir Zapolskiy <vz@mleia.com>2015-07-26 17:48:32 -0400
committerAlexandre Belloni <alexandre.belloni@free-electrons.com>2015-09-05 07:19:10 -0400
commitc472d7ded2dfbe7da29531a9c9e6b951e5658605 (patch)
treeb0e8d8f344ca4241f050d7d787b8ed700ab4456f /drivers/rtc/rtc-ds1742.c
parenta9118d77b3be366c4843446d671a52ccfddcc15c (diff)
rtc: ds1742: clean up ds1742_nvram_read()/ds1742_nvram_write()
The change removes redundant sysfs binary file boundary checks, since this task is already done on caller side in fs/sysfs/file.c Signed-off-by: Vladimir Zapolskiy <vz@mleia.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Diffstat (limited to 'drivers/rtc/rtc-ds1742.c')
-rw-r--r--drivers/rtc/rtc-ds1742.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/rtc/rtc-ds1742.c b/drivers/rtc/rtc-ds1742.c
index 0f8d8ace1515..c5168b3bcf1a 100644
--- a/drivers/rtc/rtc-ds1742.c
+++ b/drivers/rtc/rtc-ds1742.c
@@ -134,7 +134,7 @@ static ssize_t ds1742_nvram_read(struct file *filp, struct kobject *kobj,
134 void __iomem *ioaddr = pdata->ioaddr_nvram; 134 void __iomem *ioaddr = pdata->ioaddr_nvram;
135 ssize_t count; 135 ssize_t count;
136 136
137 for (count = 0; size > 0 && pos < pdata->size_nvram; count++, size--) 137 for (count = 0; count < size; count++)
138 *buf++ = readb(ioaddr + pos++); 138 *buf++ = readb(ioaddr + pos++);
139 return count; 139 return count;
140} 140}
@@ -149,7 +149,7 @@ static ssize_t ds1742_nvram_write(struct file *filp, struct kobject *kobj,
149 void __iomem *ioaddr = pdata->ioaddr_nvram; 149 void __iomem *ioaddr = pdata->ioaddr_nvram;
150 ssize_t count; 150 ssize_t count;
151 151
152 for (count = 0; size > 0 && pos < pdata->size_nvram; count++, size--) 152 for (count = 0; count < size; count++)
153 writeb(*buf++, ioaddr + pos++); 153 writeb(*buf++, ioaddr + pos++);
154 return count; 154 return count;
155} 155}