diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2013-09-11 17:24:27 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-09-11 18:58:59 -0400 |
commit | 7c1d69ee11b8986c40a53d8e2238204fc86f5b33 (patch) | |
tree | e711a10129ef7b6e060fdfa82dc7eb31f55be2d8 /drivers/rtc/rtc-ds1553.c | |
parent | 1735be4b822e8e3808f461372ff3942824790172 (diff) |
rtc: simplify devm_request_mem_region/devm_ioremap
Convert the composition of devm_request_mem_region and devm_ioremap to a
single call to devm_ioremap_resource. The associated call to
platform_get_resource is also simplified and moved next to the new call
to devm_ioremap_resource.
This was done using a combination of the semantic patches
devm_ioremap_resource.cocci and devm_request_and_ioremap.cocci, found in
the scripts/coccinelle/api directory.
In rtc-lpc32xx.c and rtc-mv.c, the local variable size is no longer needed.
In rtc-ds1511.c the size field of the local structure is not useful any
more, and is deleted.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/rtc/rtc-ds1553.c')
-rw-r--r-- | drivers/rtc/rtc-ds1553.c | 13 |
1 files changed, 4 insertions, 9 deletions
diff --git a/drivers/rtc/rtc-ds1553.c b/drivers/rtc/rtc-ds1553.c index 8c6c952e90b1..fd31571941f5 100644 --- a/drivers/rtc/rtc-ds1553.c +++ b/drivers/rtc/rtc-ds1553.c | |||
@@ -285,19 +285,14 @@ static int ds1553_rtc_probe(struct platform_device *pdev) | |||
285 | void __iomem *ioaddr; | 285 | void __iomem *ioaddr; |
286 | int ret = 0; | 286 | int ret = 0; |
287 | 287 | ||
288 | res = platform_get_resource(pdev, IORESOURCE_MEM, 0); | ||
289 | if (!res) | ||
290 | return -ENODEV; | ||
291 | pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL); | 288 | pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL); |
292 | if (!pdata) | 289 | if (!pdata) |
293 | return -ENOMEM; | 290 | return -ENOMEM; |
294 | if (!devm_request_mem_region(&pdev->dev, res->start, RTC_REG_SIZE, | ||
295 | pdev->name)) | ||
296 | return -EBUSY; | ||
297 | 291 | ||
298 | ioaddr = devm_ioremap(&pdev->dev, res->start, RTC_REG_SIZE); | 292 | res = platform_get_resource(pdev, IORESOURCE_MEM, 0); |
299 | if (!ioaddr) | 293 | ioaddr = devm_ioremap_resource(&pdev->dev, res); |
300 | return -ENOMEM; | 294 | if (IS_ERR(ioaddr)) |
295 | return PTR_ERR(ioaddr); | ||
301 | pdata->ioaddr = ioaddr; | 296 | pdata->ioaddr = ioaddr; |
302 | pdata->irq = platform_get_irq(pdev, 0); | 297 | pdata->irq = platform_get_irq(pdev, 0); |
303 | 298 | ||