diff options
author | Arnd Bergmann <arnd@arndb.de> | 2017-02-01 11:16:24 -0500 |
---|---|---|
committer | Linus Walleij <linus.walleij@linaro.org> | 2017-02-06 05:06:14 -0500 |
commit | 304c92e8fcf5863a40de60baf0576cab6b046bcf (patch) | |
tree | 794f5e6886d21b9540ca5fdfd9a5fcd93266b287 /drivers/pinctrl | |
parent | 623461e23bd56bde2db72b44742932075e30db33 (diff) |
pinctrl: samsung: mark PM functions as __maybe_unused
The rework of the suspend/resume handling uses the wrong #ifdef check, leading
to a build warning without CONFIG_PM_SLEEP:
drivers/pinctrl/samsung/pinctrl-samsung.c:1142:12: error: 'samsung_pinctrl_resume' defined but not used [-Werror=unused-function]
drivers/pinctrl/samsung/pinctrl-samsung.c:1092:12: error: 'samsung_pinctrl_suspend' defined but not used [-Werror=unused-function]
Using a __maybe_unused annotation instead of the #ifdef is a simple way to
avoid this problem class.
Fixes: 2b24efa8e5c5 ("pinctrl: samsung: Replace syscore ops with standard platform device pm_ops")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl')
-rw-r--r-- | drivers/pinctrl/samsung/pinctrl-samsung.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c index d79eadad6c5f..d601b5303e73 100644 --- a/drivers/pinctrl/samsung/pinctrl-samsung.c +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c | |||
@@ -1083,13 +1083,12 @@ static int samsung_pinctrl_probe(struct platform_device *pdev) | |||
1083 | return 0; | 1083 | return 0; |
1084 | } | 1084 | } |
1085 | 1085 | ||
1086 | #ifdef CONFIG_PM | ||
1087 | /** | 1086 | /** |
1088 | * samsung_pinctrl_suspend - save pinctrl state for suspend | 1087 | * samsung_pinctrl_suspend - save pinctrl state for suspend |
1089 | * | 1088 | * |
1090 | * Save data for all banks handled by this device. | 1089 | * Save data for all banks handled by this device. |
1091 | */ | 1090 | */ |
1092 | static int samsung_pinctrl_suspend(struct device *dev) | 1091 | static int __maybe_unused samsung_pinctrl_suspend(struct device *dev) |
1093 | { | 1092 | { |
1094 | struct samsung_pinctrl_drv_data *drvdata = dev_get_drvdata(dev); | 1093 | struct samsung_pinctrl_drv_data *drvdata = dev_get_drvdata(dev); |
1095 | int i; | 1094 | int i; |
@@ -1139,7 +1138,7 @@ static int samsung_pinctrl_suspend(struct device *dev) | |||
1139 | * We don't bother doing anything complicated to avoid glitching lines since | 1138 | * We don't bother doing anything complicated to avoid glitching lines since |
1140 | * we're called before pad retention is turned off. | 1139 | * we're called before pad retention is turned off. |
1141 | */ | 1140 | */ |
1142 | static int samsung_pinctrl_resume(struct device *dev) | 1141 | static int __maybe_unused samsung_pinctrl_resume(struct device *dev) |
1143 | { | 1142 | { |
1144 | struct samsung_pinctrl_drv_data *drvdata = dev_get_drvdata(dev); | 1143 | struct samsung_pinctrl_drv_data *drvdata = dev_get_drvdata(dev); |
1145 | int i; | 1144 | int i; |
@@ -1183,7 +1182,6 @@ static int samsung_pinctrl_resume(struct device *dev) | |||
1183 | 1182 | ||
1184 | return 0; | 1183 | return 0; |
1185 | } | 1184 | } |
1186 | #endif | ||
1187 | 1185 | ||
1188 | static const struct of_device_id samsung_pinctrl_dt_match[] = { | 1186 | static const struct of_device_id samsung_pinctrl_dt_match[] = { |
1189 | #ifdef CONFIG_PINCTRL_EXYNOS | 1187 | #ifdef CONFIG_PINCTRL_EXYNOS |