summaryrefslogtreecommitdiffstats
path: root/drivers/pinctrl/pinctrl-xway.c
diff options
context:
space:
mode:
authorLinus Walleij <linus.walleij@linaro.org>2015-12-21 10:28:11 -0500
committerLinus Walleij <linus.walleij@linaro.org>2015-12-26 16:28:35 -0500
commite15736975955639daa8a913a5f2076ba1cef58a4 (patch)
tree9c619429f6afc3402275eb654a3aa66baf4b5a38 /drivers/pinctrl/pinctrl-xway.c
parent01a62834f983455806b9e522c33d2670b83b1e52 (diff)
pinctrl: xway: Be sure to clamp return value
As we want gpio_chip .get() calls to be able to return negative error codes and propagate to drivers, we need to go over all drivers and make sure their return values are clamped to [0,1]. We do this by using the ret = !!(val) design pattern. Cc: Pramod Gurav <pramod.gurav@smartplayin.com> Cc: John Crispin <blogic@openwrt.org> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl/pinctrl-xway.c')
-rw-r--r--drivers/pinctrl/pinctrl-xway.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/pinctrl/pinctrl-xway.c b/drivers/pinctrl/pinctrl-xway.c
index e56222eac96c..ebd867f50700 100644
--- a/drivers/pinctrl/pinctrl-xway.c
+++ b/drivers/pinctrl/pinctrl-xway.c
@@ -660,7 +660,7 @@ static int xway_gpio_get(struct gpio_chip *chip, unsigned int pin)
660{ 660{
661 struct ltq_pinmux_info *info = dev_get_drvdata(chip->parent); 661 struct ltq_pinmux_info *info = dev_get_drvdata(chip->parent);
662 662
663 return gpio_getbit(info->membase[0], GPIO_IN(pin), PORT_PIN(pin)); 663 return !!gpio_getbit(info->membase[0], GPIO_IN(pin), PORT_PIN(pin));
664} 664}
665 665
666static int xway_gpio_dir_in(struct gpio_chip *chip, unsigned int pin) 666static int xway_gpio_dir_in(struct gpio_chip *chip, unsigned int pin)