diff options
author | Axel Lin <axel.lin@ingics.com> | 2015-03-31 20:45:33 -0400 |
---|---|---|
committer | Kishon Vijay Abraham I <kishon@ti.com> | 2015-04-03 08:46:21 -0400 |
commit | 407ed8357464851cf12d68c4a969cd933f8dbcaf (patch) | |
tree | e98943d6dc65dc91b340953c7c159740c5b4ba19 /drivers/phy | |
parent | 247e21c613649f34bcf2f71e57e813e6ed18b458 (diff) |
phy: spear1340-miphy: Return proper error for spear1340_miphy_xlate
The of_xlate callback should return ERR_PTR on error.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Diffstat (limited to 'drivers/phy')
-rw-r--r-- | drivers/phy/phy-spear1340-miphy.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/phy/phy-spear1340-miphy.c b/drivers/phy/phy-spear1340-miphy.c index e42bc200275f..1a00c2817f34 100644 --- a/drivers/phy/phy-spear1340-miphy.c +++ b/drivers/phy/phy-spear1340-miphy.c | |||
@@ -229,14 +229,14 @@ static struct phy *spear1340_miphy_xlate(struct device *dev, | |||
229 | 229 | ||
230 | if (args->args_count < 1) { | 230 | if (args->args_count < 1) { |
231 | dev_err(dev, "DT did not pass correct no of args\n"); | 231 | dev_err(dev, "DT did not pass correct no of args\n"); |
232 | return NULL; | 232 | return ERR_PTR(-ENODEV); |
233 | } | 233 | } |
234 | 234 | ||
235 | priv->mode = args->args[0]; | 235 | priv->mode = args->args[0]; |
236 | 236 | ||
237 | if (priv->mode != SATA && priv->mode != PCIE) { | 237 | if (priv->mode != SATA && priv->mode != PCIE) { |
238 | dev_err(dev, "DT did not pass correct phy mode\n"); | 238 | dev_err(dev, "DT did not pass correct phy mode\n"); |
239 | return NULL; | 239 | return ERR_PTR(-ENODEV); |
240 | } | 240 | } |
241 | 241 | ||
242 | return priv->phy; | 242 | return priv->phy; |