diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2018-07-12 17:29:55 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-07-15 08:13:00 -0400 |
commit | faa1a47388b33623e4d504c23569188907b039a0 (patch) | |
tree | be9c6dffb8fb64a4a2e6a2f80400180ca793189e /drivers/parport | |
parent | 45cd74cb5061781e793a098c420a7f548fdc9e7d (diff) |
parport: sunbpp: fix error return code
Return an error code on failure. Change leading spaces to tab on the
first if.
Problem found using Coccinelle.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/parport')
-rw-r--r-- | drivers/parport/parport_sunbpp.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/parport/parport_sunbpp.c b/drivers/parport/parport_sunbpp.c index 01cf1c1a841a..8de329546b82 100644 --- a/drivers/parport/parport_sunbpp.c +++ b/drivers/parport/parport_sunbpp.c | |||
@@ -286,12 +286,16 @@ static int bpp_probe(struct platform_device *op) | |||
286 | 286 | ||
287 | ops = kmemdup(&parport_sunbpp_ops, sizeof(struct parport_operations), | 287 | ops = kmemdup(&parport_sunbpp_ops, sizeof(struct parport_operations), |
288 | GFP_KERNEL); | 288 | GFP_KERNEL); |
289 | if (!ops) | 289 | if (!ops) { |
290 | err = -ENOMEM; | ||
290 | goto out_unmap; | 291 | goto out_unmap; |
292 | } | ||
291 | 293 | ||
292 | dprintk(("register_port\n")); | 294 | dprintk(("register_port\n")); |
293 | if (!(p = parport_register_port((unsigned long)base, irq, dma, ops))) | 295 | if (!(p = parport_register_port((unsigned long)base, irq, dma, ops))) { |
296 | err = -ENOMEM; | ||
294 | goto out_free_ops; | 297 | goto out_free_ops; |
298 | } | ||
295 | 299 | ||
296 | p->size = size; | 300 | p->size = size; |
297 | p->dev = &op->dev; | 301 | p->dev = &op->dev; |