diff options
author | Colin Ian King <colin.king@canonical.com> | 2018-02-01 12:29:21 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2018-02-01 14:54:28 -0500 |
commit | 5e264e2b532966bfcfe8869a3fccc9876ec2122c (patch) | |
tree | 63c5bf7ea25a3ac4208f1c9b21c2e6893847eb5f /drivers/net/vmxnet3 | |
parent | 3b51cc75eba28a7b2ca013f8255a4fd425b12b26 (diff) |
vmxnet3: remove redundant initialization of pointer 'rq'
Pointer rq is being initialized but this value is never read, it
is being updated inside a for-loop. Remove the initialization and
move it into the scope of the for-loop.
Cleans up clang warning:
drivers/net/vmxnet3/vmxnet3_drv.c:2763:27: warning: Value stored
to 'rq' during its initialization is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Shrikrishna Khare <skhare@vmware.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/vmxnet3')
-rw-r--r-- | drivers/net/vmxnet3/vmxnet3_drv.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c index cf95290b160c..8b39c160743d 100644 --- a/drivers/net/vmxnet3/vmxnet3_drv.c +++ b/drivers/net/vmxnet3/vmxnet3_drv.c | |||
@@ -2760,9 +2760,6 @@ static void | |||
2760 | vmxnet3_adjust_rx_ring_size(struct vmxnet3_adapter *adapter) | 2760 | vmxnet3_adjust_rx_ring_size(struct vmxnet3_adapter *adapter) |
2761 | { | 2761 | { |
2762 | size_t sz, i, ring0_size, ring1_size, comp_size; | 2762 | size_t sz, i, ring0_size, ring1_size, comp_size; |
2763 | struct vmxnet3_rx_queue *rq = &adapter->rx_queue[0]; | ||
2764 | |||
2765 | |||
2766 | if (adapter->netdev->mtu <= VMXNET3_MAX_SKB_BUF_SIZE - | 2763 | if (adapter->netdev->mtu <= VMXNET3_MAX_SKB_BUF_SIZE - |
2767 | VMXNET3_MAX_ETH_HDR_SIZE) { | 2764 | VMXNET3_MAX_ETH_HDR_SIZE) { |
2768 | adapter->skb_buf_size = adapter->netdev->mtu + | 2765 | adapter->skb_buf_size = adapter->netdev->mtu + |
@@ -2794,7 +2791,8 @@ vmxnet3_adjust_rx_ring_size(struct vmxnet3_adapter *adapter) | |||
2794 | comp_size = ring0_size + ring1_size; | 2791 | comp_size = ring0_size + ring1_size; |
2795 | 2792 | ||
2796 | for (i = 0; i < adapter->num_rx_queues; i++) { | 2793 | for (i = 0; i < adapter->num_rx_queues; i++) { |
2797 | rq = &adapter->rx_queue[i]; | 2794 | struct vmxnet3_rx_queue *rq = &adapter->rx_queue[i]; |
2795 | |||
2798 | rq->rx_ring[0].size = ring0_size; | 2796 | rq->rx_ring[0].size = ring0_size; |
2799 | rq->rx_ring[1].size = ring1_size; | 2797 | rq->rx_ring[1].size = ring1_size; |
2800 | rq->comp_ring.size = comp_size; | 2798 | rq->comp_ring.size = comp_size; |