summaryrefslogtreecommitdiffstats
path: root/drivers/net/macvlan.c
diff options
context:
space:
mode:
authorstephen hemminger <stephen@networkplumber.org>2017-01-06 22:12:52 -0500
committerDavid S. Miller <davem@davemloft.net>2017-01-08 17:51:44 -0500
commitbc1f44709cf27fb2a5766cadafe7e2ad5e9cb221 (patch)
tree10f4199c962083956bb3f2928e144b20be23ffe7 /drivers/net/macvlan.c
parent63c64de7be1f762b8c6c224f2994cf5769b542ae (diff)
net: make ndo_get_stats64 a void function
The network device operation for reading statistics is only called in one place, and it ignores the return value. Having a structure return value is potentially confusing because some future driver could incorrectly assume that the return value was used. Fix all drivers with ndo_get_stats64 to have a void function. Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/macvlan.c')
-rw-r--r--drivers/net/macvlan.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
index 20b3fdf282c5..440ab3d8adf7 100644
--- a/drivers/net/macvlan.c
+++ b/drivers/net/macvlan.c
@@ -855,8 +855,8 @@ static void macvlan_uninit(struct net_device *dev)
855 macvlan_port_destroy(port->dev); 855 macvlan_port_destroy(port->dev);
856} 856}
857 857
858static struct rtnl_link_stats64 *macvlan_dev_get_stats64(struct net_device *dev, 858static void macvlan_dev_get_stats64(struct net_device *dev,
859 struct rtnl_link_stats64 *stats) 859 struct rtnl_link_stats64 *stats)
860{ 860{
861 struct macvlan_dev *vlan = netdev_priv(dev); 861 struct macvlan_dev *vlan = netdev_priv(dev);
862 862
@@ -893,7 +893,6 @@ static struct rtnl_link_stats64 *macvlan_dev_get_stats64(struct net_device *dev,
893 stats->rx_dropped = rx_errors; 893 stats->rx_dropped = rx_errors;
894 stats->tx_dropped = tx_dropped; 894 stats->tx_dropped = tx_dropped;
895 } 895 }
896 return stats;
897} 896}
898 897
899static int macvlan_vlan_rx_add_vid(struct net_device *dev, 898static int macvlan_vlan_rx_add_vid(struct net_device *dev,