diff options
author | Travis Brown <travisb@arista.com> | 2018-07-09 20:35:01 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2018-07-12 02:07:22 -0400 |
commit | 80fd2d6ca5461b2752744df2e6e387cc65e7b86c (patch) | |
tree | 55ec1959f1ca3a72c9c6b4c5d8c536034f3a1482 /drivers/net/macvlan.c | |
parent | 0e97c4fb180ce90406e597a0a3f882c99ee55785 (diff) |
macvlan: Change status when lower device goes down
Today macvlan ignores the notification when a lower device goes
administratively down, preventing the lack of connectivity from
bubbling up.
Processing NETDEV_DOWN results in a macvlan state of LOWERLAYERDOWN
with NO-CARRIER which should be easy to interpret in userspace.
2: lower: <BROADCAST,MULTICAST> mtu 1500 qdisc mq state DOWN mode DEFAULT group default qlen 1000
3: macvlan@lower: <NO-CARRIER,BROADCAST,MULTICAST,UP,M-DOWN> mtu 1500 qdisc noqueue state LOWERLAYERDOWN mode DEFAULT group default qlen 1000
Signed-off-by: Suresh Krishnan <skrishnan@arista.com>
Signed-off-by: Travis Brown <travisb@arista.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/macvlan.c')
-rw-r--r-- | drivers/net/macvlan.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 401e1d1ce1ec..cfda146f3b3b 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c | |||
@@ -1641,6 +1641,7 @@ static int macvlan_device_event(struct notifier_block *unused, | |||
1641 | 1641 | ||
1642 | switch (event) { | 1642 | switch (event) { |
1643 | case NETDEV_UP: | 1643 | case NETDEV_UP: |
1644 | case NETDEV_DOWN: | ||
1644 | case NETDEV_CHANGE: | 1645 | case NETDEV_CHANGE: |
1645 | list_for_each_entry(vlan, &port->vlans, list) | 1646 | list_for_each_entry(vlan, &port->vlans, list) |
1646 | netif_stacked_transfer_operstate(vlan->lowerdev, | 1647 | netif_stacked_transfer_operstate(vlan->lowerdev, |