net: make ndo_get_stats64 a void function

The network device operation for reading statistics is only called
in one place, and it ignores the return value. Having a structure
return value is potentially confusing because some future driver could
incorrectly assume that the return value was used.

Fix all drivers with ndo_get_stats64 to have a void function.

Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 2 insertions, 4 deletions

diff --git a/drivers/net/ifb.c b/drivers/net/ifb.c
index 66c0eeafcb5d..082534e187fc 100644
--- a/drivers/net/ifb.c
+++ b/drivers/net/ifb.c
@@ -129,8 +129,8 @@ resched:
 
 }
 
-static struct rtnl_link_stats64 *ifb_stats64(struct net_device *dev,
-                                             struct rtnl_link_stats64 *stats)
+static void ifb_stats64(struct net_device *dev,
+                        struct rtnl_link_stats64 *stats)
 {
         struct ifb_dev_private *dp = netdev_priv(dev);
         struct ifb_q_private *txp = dp->tx_private;
@@ -157,8 +157,6 @@ static struct rtnl_link_stats64 *ifb_stats64(struct net_device *dev,
         }
         stats->rx_dropped = dev->stats.rx_dropped;
         stats->tx_dropped = dev->stats.tx_dropped;
-
-        return stats;
 }
 
 static int ifb_dev_init(struct net_device *dev)