summaryrefslogtreecommitdiffstats
path: root/drivers/mmc
diff options
context:
space:
mode:
authorJonathan Neuschäfer <j.neuschaefer@gmx.net>2019-02-10 12:31:07 -0500
committerUlf Hansson <ulf.hansson@linaro.org>2019-02-25 09:40:36 -0500
commitc9bd505dbd9d3dc80c496f88eafe70affdcf1ba6 (patch)
tree37340d6ee1c590fa278851b75453f3a0e78a36a1 /drivers/mmc
parent5908e6b738e3357af42c10e1183753c70a0117a9 (diff)
mmc: spi: Fix card detection during probe
When using the mmc_spi driver with a card-detect pin, I noticed that the card was not detected immediately after probe, but only after it was unplugged and plugged back in (and the CD IRQ fired). The call tree looks something like this: mmc_spi_probe mmc_add_host mmc_start_host _mmc_detect_change mmc_schedule_delayed_work(&host->detect, 0) mmc_rescan host->bus_ops->detect(host) mmc_detect _mmc_detect_card_removed host->ops->get_cd(host) mmc_gpio_get_cd -> -ENOSYS (ctx->cd_gpio not set) mmc_gpiod_request_cd ctx->cd_gpio = desc To fix this issue, call mmc_detect_change after the card-detect GPIO/IRQ is registered. Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Cc: stable@vger.kernel.org Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Diffstat (limited to 'drivers/mmc')
-rw-r--r--drivers/mmc/host/mmc_spi.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/mmc/host/mmc_spi.c b/drivers/mmc/host/mmc_spi.c
index 10ba46b728e8..8ade14fb2148 100644
--- a/drivers/mmc/host/mmc_spi.c
+++ b/drivers/mmc/host/mmc_spi.c
@@ -1450,6 +1450,7 @@ static int mmc_spi_probe(struct spi_device *spi)
1450 mmc->caps &= ~MMC_CAP_NEEDS_POLL; 1450 mmc->caps &= ~MMC_CAP_NEEDS_POLL;
1451 mmc_gpiod_request_cd_irq(mmc); 1451 mmc_gpiod_request_cd_irq(mmc);
1452 } 1452 }
1453 mmc_detect_change(mmc, 0);
1453 1454
1454 /* Index 1 is write protect/read only */ 1455 /* Index 1 is write protect/read only */
1455 status = mmc_gpiod_request_ro(mmc, NULL, 1, false, 0, NULL); 1456 status = mmc_gpiod_request_ro(mmc, NULL, 1, false, 0, NULL);