summaryrefslogtreecommitdiffstats
path: root/drivers/mmc
diff options
context:
space:
mode:
authorKamlesh Gurudasani <kamlesh.gurudasani@gmail.com>2019-05-02 01:58:16 -0400
committerUlf Hansson <ulf.hansson@linaro.org>2019-05-06 06:33:03 -0400
commitc081e7fdbf310c25d9e90ef161e905c2ef0a9dc1 (patch)
treea04f3465144bdf3808ce8114db74b273c6cb05b5 /drivers/mmc
parent26c2b19e9daf8e68a9703dfec3bd6fed7330c158 (diff)
mmc: alcor: Drop pointer to mmc_host from alcor_sdmmc_host
The driver for Alcor Micro AU6601 and AU6621 controllers uses a pointer to get from the private alcor_sdmmc_host structure to the generic mmc_host structure. However the latter is always immediately preceding the former in memory, so compute its address with a subtraction (which is cheaper than a dereference) and drop the superfluous pointer. No functional change intended. Signed-off-by: Kamlesh Gurudasani <kamlesh.gurudasani@gmail.com> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Diffstat (limited to 'drivers/mmc')
-rw-r--r--drivers/mmc/host/alcor.c15
1 files changed, 7 insertions, 8 deletions
diff --git a/drivers/mmc/host/alcor.c b/drivers/mmc/host/alcor.c
index 4b2690756453..bb53fb0a1482 100644
--- a/drivers/mmc/host/alcor.c
+++ b/drivers/mmc/host/alcor.c
@@ -43,7 +43,6 @@ struct alcor_sdmmc_host {
43 struct device *dev; 43 struct device *dev;
44 struct alcor_pci_priv *alcor_pci; 44 struct alcor_pci_priv *alcor_pci;
45 45
46 struct mmc_host *mmc;
47 struct mmc_request *mrq; 46 struct mmc_request *mrq;
48 struct mmc_command *cmd; 47 struct mmc_command *cmd;
49 struct mmc_data *data; 48 struct mmc_data *data;
@@ -293,7 +292,7 @@ static void alcor_send_cmd(struct alcor_sdmmc_host *host,
293 break; 292 break;
294 default: 293 default:
295 dev_err(host->dev, "%s: cmd->flag (0x%02x) is not valid\n", 294 dev_err(host->dev, "%s: cmd->flag (0x%02x) is not valid\n",
296 mmc_hostname(host->mmc), mmc_resp_type(cmd)); 295 mmc_hostname(mmc_from_priv(host)), mmc_resp_type(cmd));
297 break; 296 break;
298 } 297 }
299 298
@@ -334,7 +333,7 @@ static void alcor_request_complete(struct alcor_sdmmc_host *host,
334 host->data = NULL; 333 host->data = NULL;
335 host->dma_on = 0; 334 host->dma_on = 0;
336 335
337 mmc_request_done(host->mmc, mrq); 336 mmc_request_done(mmc_from_priv(host), mrq);
338} 337}
339 338
340static void alcor_finish_data(struct alcor_sdmmc_host *host) 339static void alcor_finish_data(struct alcor_sdmmc_host *host)
@@ -564,7 +563,7 @@ static void alcor_cd_irq(struct alcor_sdmmc_host *host, u32 intmask)
564 alcor_request_complete(host, 1); 563 alcor_request_complete(host, 1);
565 } 564 }
566 565
567 mmc_detect_change(host->mmc, msecs_to_jiffies(1)); 566 mmc_detect_change(mmc_from_priv(host), msecs_to_jiffies(1));
568} 567}
569 568
570static irqreturn_t alcor_irq_thread(int irq, void *d) 569static irqreturn_t alcor_irq_thread(int irq, void *d)
@@ -1049,7 +1048,7 @@ static void alcor_hw_uninit(struct alcor_sdmmc_host *host)
1049 1048
1050static void alcor_init_mmc(struct alcor_sdmmc_host *host) 1049static void alcor_init_mmc(struct alcor_sdmmc_host *host)
1051{ 1050{
1052 struct mmc_host *mmc = host->mmc; 1051 struct mmc_host *mmc = mmc_from_priv(host);
1053 1052
1054 mmc->f_min = AU6601_MIN_CLOCK; 1053 mmc->f_min = AU6601_MIN_CLOCK;
1055 mmc->f_max = AU6601_MAX_CLOCK; 1054 mmc->f_max = AU6601_MAX_CLOCK;
@@ -1092,7 +1091,6 @@ static int alcor_pci_sdmmc_drv_probe(struct platform_device *pdev)
1092 } 1091 }
1093 1092
1094 host = mmc_priv(mmc); 1093 host = mmc_priv(mmc);
1095 host->mmc = mmc;
1096 host->dev = &pdev->dev; 1094 host->dev = &pdev->dev;
1097 host->cur_power_mode = MMC_POWER_UNDEFINED; 1095 host->cur_power_mode = MMC_POWER_UNDEFINED;
1098 host->alcor_pci = priv; 1096 host->alcor_pci = priv;
@@ -1124,13 +1122,14 @@ static int alcor_pci_sdmmc_drv_probe(struct platform_device *pdev)
1124static int alcor_pci_sdmmc_drv_remove(struct platform_device *pdev) 1122static int alcor_pci_sdmmc_drv_remove(struct platform_device *pdev)
1125{ 1123{
1126 struct alcor_sdmmc_host *host = dev_get_drvdata(&pdev->dev); 1124 struct alcor_sdmmc_host *host = dev_get_drvdata(&pdev->dev);
1125 struct mmc_host *mmc = mmc_from_priv(host);
1127 1126
1128 if (cancel_delayed_work_sync(&host->timeout_work)) 1127 if (cancel_delayed_work_sync(&host->timeout_work))
1129 alcor_request_complete(host, 0); 1128 alcor_request_complete(host, 0);
1130 1129
1131 alcor_hw_uninit(host); 1130 alcor_hw_uninit(host);
1132 mmc_remove_host(host->mmc); 1131 mmc_remove_host(mmc);
1133 mmc_free_host(host->mmc); 1132 mmc_free_host(mmc);
1134 1133
1135 return 0; 1134 return 0;
1136} 1135}