diff options
author | Hannes Reinecke <hare@suse.de> | 2018-09-28 02:17:19 -0400 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2018-09-28 10:30:28 -0400 |
commit | fef912bf860e8e7e48a2bfb978a356bba743a8b7 (patch) | |
tree | 5cc5e4a4a02c9b898a1afc8e056664b762a1c852 /drivers/memstick | |
parent | 6c3b7af1c975b87b86dcb2af233d1ae21eb05107 (diff) |
block: genhd: add 'groups' argument to device_add_disk
Update device_add_disk() to take an 'groups' argument so that
individual drivers can register a device with additional sysfs
attributes.
This avoids race condition the driver would otherwise have if these
groups were to be created with sysfs_add_groups().
Signed-off-by: Martin Wilck <martin.wilck@suse.com>
Signed-off-by: Hannes Reinecke <hare@suse.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/memstick')
-rw-r--r-- | drivers/memstick/core/ms_block.c | 2 | ||||
-rw-r--r-- | drivers/memstick/core/mspro_block.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/drivers/memstick/core/ms_block.c b/drivers/memstick/core/ms_block.c index 716fc8ed31d3..8a02f11076f9 100644 --- a/drivers/memstick/core/ms_block.c +++ b/drivers/memstick/core/ms_block.c | |||
@@ -2146,7 +2146,7 @@ static int msb_init_disk(struct memstick_dev *card) | |||
2146 | set_disk_ro(msb->disk, 1); | 2146 | set_disk_ro(msb->disk, 1); |
2147 | 2147 | ||
2148 | msb_start(card); | 2148 | msb_start(card); |
2149 | device_add_disk(&card->dev, msb->disk); | 2149 | device_add_disk(&card->dev, msb->disk, NULL); |
2150 | dbg("Disk added"); | 2150 | dbg("Disk added"); |
2151 | return 0; | 2151 | return 0; |
2152 | 2152 | ||
diff --git a/drivers/memstick/core/mspro_block.c b/drivers/memstick/core/mspro_block.c index 5ee932631fae..0cd30dcb6801 100644 --- a/drivers/memstick/core/mspro_block.c +++ b/drivers/memstick/core/mspro_block.c | |||
@@ -1236,7 +1236,7 @@ static int mspro_block_init_disk(struct memstick_dev *card) | |||
1236 | set_capacity(msb->disk, capacity); | 1236 | set_capacity(msb->disk, capacity); |
1237 | dev_dbg(&card->dev, "capacity set %ld\n", capacity); | 1237 | dev_dbg(&card->dev, "capacity set %ld\n", capacity); |
1238 | 1238 | ||
1239 | device_add_disk(&card->dev, msb->disk); | 1239 | device_add_disk(&card->dev, msb->disk, NULL); |
1240 | msb->active = 1; | 1240 | msb->active = 1; |
1241 | return 0; | 1241 | return 0; |
1242 | 1242 | ||