summaryrefslogtreecommitdiffstats
path: root/drivers/media
diff options
context:
space:
mode:
authorPeter Rosin <peda@axentia.se>2018-06-20 01:17:57 -0400
committerWolfram Sang <wsa@the-dreams.de>2018-07-12 18:09:16 -0400
commitb1e1ca27570016e3aa0e3265df699fea87013abc (patch)
treeeef2875650bab15cd21da666ccf42f64f689cba8 /drivers/media
parent193c2a07cfaacb9249ab0e3d34bce32490879355 (diff)
media: af9013: switch to i2c_lock_bus(..., I2C_LOCK_SEGMENT)
Locking the root adapter for __i2c_transfer will deadlock if the device sits behind a mux-locked I2C mux. Switch to the finer-grained i2c_lock_bus with the I2C_LOCK_SEGMENT flag. If the device does not sit behind a mux-locked mux, the two locking variants are equivalent. Signed-off-by: Peter Rosin <peda@axentia.se> Acked-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Diffstat (limited to 'drivers/media')
-rw-r--r--drivers/media/dvb-frontends/af9013.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/media/dvb-frontends/af9013.c b/drivers/media/dvb-frontends/af9013.c
index 482bce49819a..99361c113bca 100644
--- a/drivers/media/dvb-frontends/af9013.c
+++ b/drivers/media/dvb-frontends/af9013.c
@@ -1312,10 +1312,10 @@ static int af9013_wregs(struct i2c_client *client, u8 cmd, u16 reg,
1312 memcpy(&buf[3], val, len); 1312 memcpy(&buf[3], val, len);
1313 1313
1314 if (lock) 1314 if (lock)
1315 i2c_lock_adapter(client->adapter); 1315 i2c_lock_bus(client->adapter, I2C_LOCK_SEGMENT);
1316 ret = __i2c_transfer(client->adapter, msg, 1); 1316 ret = __i2c_transfer(client->adapter, msg, 1);
1317 if (lock) 1317 if (lock)
1318 i2c_unlock_adapter(client->adapter); 1318 i2c_unlock_bus(client->adapter, I2C_LOCK_SEGMENT);
1319 if (ret < 0) { 1319 if (ret < 0) {
1320 goto err; 1320 goto err;
1321 } else if (ret != 1) { 1321 } else if (ret != 1) {
@@ -1353,10 +1353,10 @@ static int af9013_rregs(struct i2c_client *client, u8 cmd, u16 reg,
1353 buf[2] = cmd; 1353 buf[2] = cmd;
1354 1354
1355 if (lock) 1355 if (lock)
1356 i2c_lock_adapter(client->adapter); 1356 i2c_lock_bus(client->adapter, I2C_LOCK_SEGMENT);
1357 ret = __i2c_transfer(client->adapter, msg, 2); 1357 ret = __i2c_transfer(client->adapter, msg, 2);
1358 if (lock) 1358 if (lock)
1359 i2c_unlock_adapter(client->adapter); 1359 i2c_unlock_bus(client->adapter, I2C_LOCK_SEGMENT);
1360 if (ret < 0) { 1360 if (ret < 0) {
1361 goto err; 1361 goto err;
1362 } else if (ret != 2) { 1362 } else if (ret != 2) {