summaryrefslogtreecommitdiffstats
path: root/drivers/media
diff options
context:
space:
mode:
authorSachin Kamat <sachin.kamat@linaro.org>2012-09-24 01:17:48 -0400
committerMauro Carvalho Chehab <mchehab@redhat.com>2012-10-06 10:51:54 -0400
commit38a7996cbb26ddd6b595e2fafa9742aefcb2f115 (patch)
treedea7777f2c8c2f69d54ceaea098ac79b41f31c0e /drivers/media
parent26fdcf0980225f8b3d5fa258d9f41433cb0664ed (diff)
[media] mem2mem_testdev: Use devm_kzalloc() in probe
devm_kzalloc() makes error handling and cleanup simpler. Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Acked-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media')
-rw-r--r--drivers/media/platform/mem2mem_testdev.c7
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/media/platform/mem2mem_testdev.c b/drivers/media/platform/mem2mem_testdev.c
index 7627335816e4..2e2121e98133 100644
--- a/drivers/media/platform/mem2mem_testdev.c
+++ b/drivers/media/platform/mem2mem_testdev.c
@@ -1019,7 +1019,7 @@ static int m2mtest_probe(struct platform_device *pdev)
1019 struct video_device *vfd; 1019 struct video_device *vfd;
1020 int ret; 1020 int ret;
1021 1021
1022 dev = kzalloc(sizeof(*dev), GFP_KERNEL); 1022 dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL);
1023 if (!dev) 1023 if (!dev)
1024 return -ENOMEM; 1024 return -ENOMEM;
1025 1025
@@ -1027,7 +1027,7 @@ static int m2mtest_probe(struct platform_device *pdev)
1027 1027
1028 ret = v4l2_device_register(&pdev->dev, &dev->v4l2_dev); 1028 ret = v4l2_device_register(&pdev->dev, &dev->v4l2_dev);
1029 if (ret) 1029 if (ret)
1030 goto free_dev; 1030 return ret;
1031 1031
1032 atomic_set(&dev->num_inst, 0); 1032 atomic_set(&dev->num_inst, 0);
1033 mutex_init(&dev->dev_mutex); 1033 mutex_init(&dev->dev_mutex);
@@ -1073,8 +1073,6 @@ rel_vdev:
1073 video_device_release(vfd); 1073 video_device_release(vfd);
1074unreg_dev: 1074unreg_dev:
1075 v4l2_device_unregister(&dev->v4l2_dev); 1075 v4l2_device_unregister(&dev->v4l2_dev);
1076free_dev:
1077 kfree(dev);
1078 1076
1079 return ret; 1077 return ret;
1080} 1078}
@@ -1089,7 +1087,6 @@ static int m2mtest_remove(struct platform_device *pdev)
1089 del_timer_sync(&dev->timer); 1087 del_timer_sync(&dev->timer);
1090 video_unregister_device(dev->vfd); 1088 video_unregister_device(dev->vfd);
1091 v4l2_device_unregister(&dev->v4l2_dev); 1089 v4l2_device_unregister(&dev->v4l2_dev);
1092 kfree(dev);
1093 1090
1094 return 0; 1091 return 0;
1095} 1092}