summaryrefslogtreecommitdiffstats
path: root/drivers/media
diff options
context:
space:
mode:
authorMalcolm Priestley <tvboxspy@gmail.com>2015-01-02 08:56:28 -0500
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>2015-02-03 14:14:42 -0500
commit15e1ce33182d1d5dbd8efe8d382b9352dc857527 (patch)
tree3e7a7412642fcebc6cd6002849d61bc8a0e7ec9b /drivers/media
parentcfcd7b825892cb498c6bcb13257f2141f7eacb76 (diff)
[media] lmedm04: Fix usb_submit_urb BOGUS urb xfer, pipe 1 != type 3 in interrupt urb
A quirk of some older firmwares that report endpoint pipe type as PIPE_BULK but the endpoint otheriwse functions as interrupt. Check if usb_endpoint_type is USB_ENDPOINT_XFER_BULK and set as usb_rcvbulkpipe. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Cc: <stable@vger.kernel.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Diffstat (limited to 'drivers/media')
-rw-r--r--drivers/media/usb/dvb-usb-v2/lmedm04.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/drivers/media/usb/dvb-usb-v2/lmedm04.c b/drivers/media/usb/dvb-usb-v2/lmedm04.c
index f1edb299c2f2..15db9f67f4d1 100644
--- a/drivers/media/usb/dvb-usb-v2/lmedm04.c
+++ b/drivers/media/usb/dvb-usb-v2/lmedm04.c
@@ -354,6 +354,7 @@ static int lme2510_int_read(struct dvb_usb_adapter *adap)
354{ 354{
355 struct dvb_usb_device *d = adap_to_d(adap); 355 struct dvb_usb_device *d = adap_to_d(adap);
356 struct lme2510_state *lme_int = adap_to_priv(adap); 356 struct lme2510_state *lme_int = adap_to_priv(adap);
357 struct usb_host_endpoint *ep;
357 358
358 lme_int->lme_urb = usb_alloc_urb(0, GFP_ATOMIC); 359 lme_int->lme_urb = usb_alloc_urb(0, GFP_ATOMIC);
359 360
@@ -375,6 +376,12 @@ static int lme2510_int_read(struct dvb_usb_adapter *adap)
375 adap, 376 adap,
376 8); 377 8);
377 378
379 /* Quirk of pipe reporting PIPE_BULK but behaves as interrupt */
380 ep = usb_pipe_endpoint(d->udev, lme_int->lme_urb->pipe);
381
382 if (usb_endpoint_type(&ep->desc) == USB_ENDPOINT_XFER_BULK)
383 lme_int->lme_urb->pipe = usb_rcvbulkpipe(d->udev, 0xa),
384
378 lme_int->lme_urb->transfer_flags |= URB_NO_TRANSFER_DMA_MAP; 385 lme_int->lme_urb->transfer_flags |= URB_NO_TRANSFER_DMA_MAP;
379 386
380 usb_submit_urb(lme_int->lme_urb, GFP_ATOMIC); 387 usb_submit_urb(lme_int->lme_urb, GFP_ATOMIC);