diff options
author | Rusty Russell <rusty@rustcorp.com.au> | 2012-01-12 18:02:20 -0500 |
---|---|---|
committer | Rusty Russell <rusty@rustcorp.com.au> | 2012-01-12 18:02:20 -0500 |
commit | 90ab5ee94171b3e28de6bb42ee30b527014e0be7 (patch) | |
tree | fcf89889f6e881f2b231d3d20287c08174ce4b54 /drivers/macintosh/ams | |
parent | 476bc0015bf09dad39d36a8b19f76f0c181d1ec9 (diff) |
module_param: make bool parameters really bool (drivers & misc)
module_param(bool) used to counter-intuitively take an int. In
fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
trick.
It's time to remove the int/unsigned int option. For this version
it'll simply give a warning, but it'll break next kernel version.
Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Diffstat (limited to 'drivers/macintosh/ams')
-rw-r--r-- | drivers/macintosh/ams/ams-core.c | 2 | ||||
-rw-r--r-- | drivers/macintosh/ams/ams-input.c | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/drivers/macintosh/ams/ams-core.c b/drivers/macintosh/ams/ams-core.c index 399beb1638d1..5c6a2d876562 100644 --- a/drivers/macintosh/ams/ams-core.c +++ b/drivers/macintosh/ams/ams-core.c | |||
@@ -31,7 +31,7 @@ | |||
31 | /* There is only one motion sensor per machine */ | 31 | /* There is only one motion sensor per machine */ |
32 | struct ams ams_info; | 32 | struct ams ams_info; |
33 | 33 | ||
34 | static unsigned int verbose; | 34 | static bool verbose; |
35 | module_param(verbose, bool, 0644); | 35 | module_param(verbose, bool, 0644); |
36 | MODULE_PARM_DESC(verbose, "Show free falls and shocks in kernel output"); | 36 | MODULE_PARM_DESC(verbose, "Show free falls and shocks in kernel output"); |
37 | 37 | ||
diff --git a/drivers/macintosh/ams/ams-input.c b/drivers/macintosh/ams/ams-input.c index 8a712392cd38..b27e530a87a4 100644 --- a/drivers/macintosh/ams/ams-input.c +++ b/drivers/macintosh/ams/ams-input.c | |||
@@ -19,11 +19,11 @@ | |||
19 | 19 | ||
20 | #include "ams.h" | 20 | #include "ams.h" |
21 | 21 | ||
22 | static unsigned int joystick; | 22 | static bool joystick; |
23 | module_param(joystick, bool, S_IRUGO); | 23 | module_param(joystick, bool, S_IRUGO); |
24 | MODULE_PARM_DESC(joystick, "Enable the input class device on module load"); | 24 | MODULE_PARM_DESC(joystick, "Enable the input class device on module load"); |
25 | 25 | ||
26 | static unsigned int invert; | 26 | static bool invert; |
27 | module_param(invert, bool, S_IWUSR | S_IRUGO); | 27 | module_param(invert, bool, S_IWUSR | S_IRUGO); |
28 | MODULE_PARM_DESC(invert, "Invert input data on X and Y axis"); | 28 | MODULE_PARM_DESC(invert, "Invert input data on X and Y axis"); |
29 | 29 | ||