Input: convert obsolete strict_strtox to kstrtox

With commit 67d0a0754455f89ef3946946159d8ec9e45ce33a we mark strict_strtox
as obsolete. Convert all remaining such uses in drivers/input/.

Also change long to appropriate types, and return error conditions
from kstrtox separately, as Dmitry sugguests.

Signed-off-by: JJ Ding <dgdunix@gmail.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>

6 files changed, 80 insertions, 41 deletions

diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
index 09b93b11a274..b562392d0cd8 100644
--- a/drivers/input/mouse/elantech.c
+++ b/drivers/input/mouse/elantech.c
@@ -1031,16 +1031,13 @@ static ssize_t elantech_set_int_attr(struct psmouse *psmouse,
         struct elantech_data *etd = psmouse->private;
         struct elantech_attr_data *attr = data;
         unsigned char *reg = (unsigned char *) etd + attr->field_offset;
-        unsigned long value;
+        unsigned char value;
         int err;
 
-        err = strict_strtoul(buf, 16, &value);
+        err = kstrtou8(buf, 16, &value);
         if (err)
                 return err;
 
-        if (value > 0xff)
-                return -EINVAL;
-
         /* Do we need to preserve some bits for version 2 hardware too? */
         if (etd->hw_version == 1) {
                 if (attr->reg == 0x10)
diff --git a/drivers/input/mouse/hgpk.c b/drivers/input/mouse/hgpk.c
index 0470dd46b566..1c5d521de600 100644
--- a/drivers/input/mouse/hgpk.c
+++ b/drivers/input/mouse/hgpk.c
@@ -789,11 +789,14 @@ static ssize_t hgpk_set_powered(struct psmouse *psmouse, void *data,
                                 const char *buf, size_t count)
 {
         struct hgpk_data *priv = psmouse->private;
-        unsigned long value;
+        unsigned int value;
         int err;
 
-        err = strict_strtoul(buf, 10, &value);
-        if (err || value > 1)
+        err = kstrtouint(buf, 10, &value);
+        if (err)
+                return err;
+
+        if (value > 1)
                 return -EINVAL;
 
         if (value != priv->powered) {
@@ -881,11 +884,14 @@ static ssize_t hgpk_trigger_recal(struct psmouse *psmouse, void *data,
                                 const char *buf, size_t count)
 {
         struct hgpk_data *priv = psmouse->private;
-        unsigned long value;
+        unsigned int value;
         int err;
 
-        err = strict_strtoul(buf, 10, &value);
-        if (err || value != 1)
+        err = kstrtouint(buf, 10, &value);
+        if (err)
+                return err;
+
+        if (value != 1)
                 return -EINVAL;
 
         /*
diff --git a/drivers/input/mouse/logips2pp.c b/drivers/input/mouse/logips2pp.c
index faac2c3bef74..84de2fc6acc1 100644
--- a/drivers/input/mouse/logips2pp.c
+++ b/drivers/input/mouse/logips2pp.c
@@ -155,9 +155,14 @@ static ssize_t ps2pp_attr_show_smartscroll(struct psmouse *psmouse,
 static ssize_t ps2pp_attr_set_smartscroll(struct psmouse *psmouse, void *data,
                                           const char *buf, size_t count)
 {
-        unsigned long value;
+        unsigned int value;
+        int err;
 
-        if (strict_strtoul(buf, 10, &value) || value > 1)
+        err = kstrtouint(buf, 10, &value);
+        if (err)
+                return err;
+
+        if (value > 1)
                 return -EINVAL;
 
         ps2pp_set_smartscroll(psmouse, value);
diff --git a/drivers/input/mouse/psmouse-base.c b/drivers/input/mouse/psmouse-base.c
index 9f352fbd7b4f..a6973e575aa9 100644
--- a/drivers/input/mouse/psmouse-base.c
+++ b/drivers/input/mouse/psmouse-base.c
@@ -1558,13 +1558,12 @@ static ssize_t psmouse_show_int_attr(struct psmouse *psmouse, void *offset, char
 static ssize_t psmouse_set_int_attr(struct psmouse *psmouse, void *offset, const char *buf, size_t count)
 {
         unsigned int *field = (unsigned int *)((char *)psmouse + (size_t)offset);
-        unsigned long value;
-
-        if (strict_strtoul(buf, 10, &value))
-                return -EINVAL;
+        unsigned int value;
+        int err;
 
-        if ((unsigned int)value != value)
-                return -EINVAL;
+        err = kstrtouint(buf, 10, &value);
+        if (err)
+                return err;
 
         *field = value;
 
@@ -1671,10 +1670,12 @@ static ssize_t psmouse_attr_set_protocol(struct psmouse *psmouse, void *data, co
 
 static ssize_t psmouse_attr_set_rate(struct psmouse *psmouse, void *data, const char *buf, size_t count)
 {
-        unsigned long value;
+        unsigned int value;
+        int err;
 
-        if (strict_strtoul(buf, 10, &value))
-                return -EINVAL;
+        err = kstrtouint(buf, 10, &value);
+        if (err)
+                return err;
 
         psmouse->set_rate(psmouse, value);
         return count;
@@ -1682,10 +1683,12 @@ static ssize_t psmouse_attr_set_rate(struct psmouse *psmouse, void *data, const
 
 static ssize_t psmouse_attr_set_resolution(struct psmouse *psmouse, void *data, const char *buf, size_t count)
 {
-        unsigned long value;
+        unsigned int value;
+        int err;
 
-        if (strict_strtoul(buf, 10, &value))
-                return -EINVAL;
+        err = kstrtouint(buf, 10, &value);
+        if (err)
+                return err;
 
         psmouse->set_resolution(psmouse, value);
         return count;
diff --git a/drivers/input/mouse/sentelic.c b/drivers/input/mouse/sentelic.c
index c5b12d2e955a..5babc47b39aa 100644
--- a/drivers/input/mouse/sentelic.c
+++ b/drivers/input/mouse/sentelic.c
@@ -408,7 +408,7 @@ static int fsp_onpad_hscr(struct psmouse *psmouse, bool enable)
 static ssize_t fsp_attr_set_setreg(struct psmouse *psmouse, void *data,
                                    const char *buf, size_t count)
 {
-        unsigned long reg, val;
+        int reg, val;
         char *rest;
         ssize_t retval;
 
@@ -416,7 +416,11 @@ static ssize_t fsp_attr_set_setreg(struct psmouse *psmouse, void *data,
         if (rest == buf || *rest != ' ' || reg > 0xff)
                 return -EINVAL;
 
-        if (strict_strtoul(rest + 1, 16, &val) || val > 0xff)
+        retval = kstrtoint(rest + 1, 16, &val);
+        if (retval)
+                return retval;
+
+        if (val > 0xff)
                 return -EINVAL;
 
         if (fsp_reg_write_enable(psmouse, true))
@@ -448,10 +452,13 @@ static ssize_t fsp_attr_set_getreg(struct psmouse *psmouse, void *data,
                                         const char *buf, size_t count)
 {
         struct fsp_data *pad = psmouse->private;
-        unsigned long reg;
-        int val;
+        int reg, val, err;
+
+        err = kstrtoint(buf, 16, &reg);
+        if (err)
+                return err;
 
-        if (strict_strtoul(buf, 16, &reg) || reg > 0xff)
+        if (reg > 0xff)
                 return -EINVAL;
 
         if (fsp_reg_read(psmouse, reg, &val))
@@ -480,9 +487,13 @@ static ssize_t fsp_attr_show_pagereg(struct psmouse *psmouse,
 static ssize_t fsp_attr_set_pagereg(struct psmouse *psmouse, void *data,
                                         const char *buf, size_t count)
 {
-        unsigned long val;
+        int val, err;
 
-        if (strict_strtoul(buf, 16, &val) || val > 0xff)
+        err = kstrtoint(buf, 16, &val);
+        if (err)
+                return err;
+
+        if (val > 0xff)
                 return -EINVAL;
 
         if (fsp_page_reg_write(psmouse, val))
@@ -505,9 +516,14 @@ static ssize_t fsp_attr_show_vscroll(struct psmouse *psmouse,
 static ssize_t fsp_attr_set_vscroll(struct psmouse *psmouse, void *data,
                                         const char *buf, size_t count)
 {
-        unsigned long val;
+        unsigned int val;
+        int err;
+
+        err = kstrtouint(buf, 10, &val);
+        if (err)
+                return err;
 
-        if (strict_strtoul(buf, 10, &val) || val > 1)
+        if (val > 1)
                 return -EINVAL;
 
         fsp_onpad_vscr(psmouse, val);
@@ -529,9 +545,14 @@ static ssize_t fsp_attr_show_hscroll(struct psmouse *psmouse,
 static ssize_t fsp_attr_set_hscroll(struct psmouse *psmouse, void *data,
                                         const char *buf, size_t count)
 {
-        unsigned long val;
+        unsigned int val;
+        int err;
+
+        err = kstrtouint(buf, 10, &val);
+        if (err)
+                return err;
 
-        if (strict_strtoul(buf, 10, &val) || val > 1)
+        if (val > 1)
                 return -EINVAL;
 
         fsp_onpad_hscr(psmouse, val);
diff --git a/drivers/input/mouse/trackpoint.c b/drivers/input/mouse/trackpoint.c
index 54b2fa892e19..22b218018137 100644
--- a/drivers/input/mouse/trackpoint.c
+++ b/drivers/input/mouse/trackpoint.c
@@ -89,10 +89,12 @@ static ssize_t trackpoint_set_int_attr(struct psmouse *psmouse, void *data,
         struct trackpoint_data *tp = psmouse->private;
         struct trackpoint_attr_data *attr = data;
         unsigned char *field = (unsigned char *)((char *)tp + attr->field_offset);
-        unsigned long value;
+        unsigned char value;
+        int err;
 
-        if (strict_strtoul(buf, 10, &value) || value > 255)
-                return -EINVAL;
+        err = kstrtou8(buf, 10, &value);
+        if (err)
+                return err;
 
         *field = value;
         trackpoint_write(&psmouse->ps2dev, attr->command, value);
@@ -115,9 +117,14 @@ static ssize_t trackpoint_set_bit_attr(struct psmouse *psmouse, void *data,
         struct trackpoint_data *tp = psmouse->private;
         struct trackpoint_attr_data *attr = data;
         unsigned char *field = (unsigned char *)((char *)tp + attr->field_offset);
-        unsigned long value;
+        unsigned int value;
+        int err;
+
+        err = kstrtouint(buf, 10, &value);
+        if (err)
+                return err;
 
-        if (strict_strtoul(buf, 10, &value) || value > 1)
+        if (value > 1)
                 return -EINVAL;
 
         if (attr->inverted)