summaryrefslogtreecommitdiffstats
path: root/drivers/input/misc
diff options
context:
space:
mode:
authorDmitry Torokhov <dmitry.torokhov@gmail.com>2017-09-06 19:31:29 -0400
committerDmitry Torokhov <dmitry.torokhov@gmail.com>2017-10-23 19:32:29 -0400
commit8e009118a45af30451ff4bbae2b6efd9575d6694 (patch)
tree2b5ee42caeaa13d96874ef0003313cb201a0de75 /drivers/input/misc
parent8446b32b0675b432451bdb35bd193597477f1bfa (diff)
Input: uinput - allow FF requests to time out
Previously uinput force feedback requests waited for the userspace indefinitely, which caused users to block when uinput server process become unresponsive. Let's establish a 30 seconds deadline for servicing upload and erase force feedback effect actions, so that users have a chance to abort stuck requests. Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Diffstat (limited to 'drivers/input/misc')
-rw-r--r--drivers/input/misc/uinput.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/input/misc/uinput.c b/drivers/input/misc/uinput.c
index 443151de90c6..c30704fa1a06 100644
--- a/drivers/input/misc/uinput.c
+++ b/drivers/input/misc/uinput.c
@@ -149,7 +149,11 @@ static int uinput_request_submit(struct uinput_device *udev,
149 if (retval) 149 if (retval)
150 goto out; 150 goto out;
151 151
152 wait_for_completion(&request->done); 152 if (!wait_for_completion_timeout(&request->done, 30 * HZ)) {
153 retval = -ETIMEDOUT;
154 goto out;
155 }
156
153 retval = request->retval; 157 retval = request->retval;
154 158
155 out: 159 out: