diff options
author | Zhu Yanjun <yanjun.zhu@oracle.com> | 2018-05-17 04:55:22 -0400 |
---|---|---|
committer | Jason Gunthorpe <jgg@mellanox.com> | 2018-05-17 11:16:14 -0400 |
commit | da2f3b286a396928e9ddcb8c9a987597e751aa84 (patch) | |
tree | b44153806609ea82452a81148609f7a11cc71516 /drivers/infiniband/sw | |
parent | 5e6e78dbd3b93414ca53af5d51c090878d1c9e5d (diff) |
IB/rxe: avoid calling WARN_ON_ONCE twice
In the exit branch, WARN_ON_ONCE is called to show stack. So it is
not necessary to call WARN_ON_ONCE before going to exit.
Signed-off-by: Zhu Yanjun <yanjun.zhu@oracle.com>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Diffstat (limited to 'drivers/infiniband/sw')
-rw-r--r-- | drivers/infiniband/sw/rxe/rxe_comp.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/infiniband/sw/rxe/rxe_comp.c b/drivers/infiniband/sw/rxe/rxe_comp.c index a285978aa7fe..98d470d1f3fc 100644 --- a/drivers/infiniband/sw/rxe/rxe_comp.c +++ b/drivers/infiniband/sw/rxe/rxe_comp.c | |||
@@ -659,7 +659,6 @@ int rxe_completer(void *arg) | |||
659 | qp->qp_timeout_jiffies) | 659 | qp->qp_timeout_jiffies) |
660 | mod_timer(&qp->retrans_timer, | 660 | mod_timer(&qp->retrans_timer, |
661 | jiffies + qp->qp_timeout_jiffies); | 661 | jiffies + qp->qp_timeout_jiffies); |
662 | WARN_ON_ONCE(skb); | ||
663 | goto exit; | 662 | goto exit; |
664 | 663 | ||
665 | case COMPST_ERROR_RETRY: | 664 | case COMPST_ERROR_RETRY: |
@@ -673,7 +672,6 @@ int rxe_completer(void *arg) | |||
673 | 672 | ||
674 | /* there is nothing to retry in this case */ | 673 | /* there is nothing to retry in this case */ |
675 | if (!wqe || (wqe->state == wqe_state_posted)) { | 674 | if (!wqe || (wqe->state == wqe_state_posted)) { |
676 | WARN_ON_ONCE(skb); | ||
677 | goto exit; | 675 | goto exit; |
678 | } | 676 | } |
679 | 677 | ||
@@ -702,7 +700,6 @@ int rxe_completer(void *arg) | |||
702 | skb = NULL; | 700 | skb = NULL; |
703 | } | 701 | } |
704 | 702 | ||
705 | WARN_ON_ONCE(skb); | ||
706 | goto exit; | 703 | goto exit; |
707 | 704 | ||
708 | } else { | 705 | } else { |
@@ -746,7 +743,6 @@ int rxe_completer(void *arg) | |||
746 | skb = NULL; | 743 | skb = NULL; |
747 | } | 744 | } |
748 | 745 | ||
749 | WARN_ON_ONCE(skb); | ||
750 | goto exit; | 746 | goto exit; |
751 | } | 747 | } |
752 | } | 748 | } |