diff options
| author | Guenter Roeck <linux@roeck-us.net> | 2015-07-04 16:23:42 -0400 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2015-07-29 23:06:50 -0400 |
| commit | 9200bc4c28cd8992eb5379345abd6b4f0c93df16 (patch) | |
| tree | a775ada60b166e99a1860cfb2cde1bd37ca15c26 /drivers/hwmon/nct7802.c | |
| parent | 0d6aaffc3a6db642e0a165ba4d17d6d7bbaf5201 (diff) | |
hwmon: (nct7802) Fix integer overflow seen when writing voltage limits
Writing a large value into a voltage limit attribute can result
in an overflow due to an auto-conversion from unsigned long to
unsigned int.
Cc: Constantine Shulyupin <const@MakeLinux.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Cc: stable@vger.kernel.org # v4.1+
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon/nct7802.c')
| -rw-r--r-- | drivers/hwmon/nct7802.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/nct7802.c b/drivers/hwmon/nct7802.c index 28fcb2e246d5..fbfc02bb2cfa 100644 --- a/drivers/hwmon/nct7802.c +++ b/drivers/hwmon/nct7802.c | |||
| @@ -195,7 +195,7 @@ abort: | |||
| 195 | } | 195 | } |
| 196 | 196 | ||
| 197 | static int nct7802_write_voltage(struct nct7802_data *data, int nr, int index, | 197 | static int nct7802_write_voltage(struct nct7802_data *data, int nr, int index, |
| 198 | unsigned int voltage) | 198 | unsigned long voltage) |
| 199 | { | 199 | { |
| 200 | int shift = 8 - REG_VOLTAGE_LIMIT_MSB_SHIFT[index - 1][nr]; | 200 | int shift = 8 - REG_VOLTAGE_LIMIT_MSB_SHIFT[index - 1][nr]; |
| 201 | int err; | 201 | int err; |