summaryrefslogtreecommitdiffstats
path: root/drivers/hid/hid-prodikeys.c
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2019-09-05 12:54:06 -0400
committerJiri Kosina <jkosina@suse.cz>2019-10-01 10:21:04 -0400
commitfe2199cfd1516e90e03c033c52c9a28da09d9986 (patch)
treec9a48de7f4bd02608f01094d0df450767ac0fafb /drivers/hid/hid-prodikeys.c
parentb3a81c777dcb093020680490ab970d85e2f6f04f (diff)
HID: prodikeys: make array keys static const, makes object smaller
Don't populate the array keys on the stack but instead make it static const. Makes the object code smaller by 166 bytes. Before: text data bss dec hex filename 18931 5872 480 25283 62c3 drivers/hid/hid-prodikeys.o After: text data bss dec hex filename 18669 5968 480 25117 621d drivers/hid/hid-prodikeys.o (gcc version 9.2.1, amd64) Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid/hid-prodikeys.c')
-rw-r--r--drivers/hid/hid-prodikeys.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/hid/hid-prodikeys.c b/drivers/hid/hid-prodikeys.c
index 5a3b3d974d84..2666af02d5c1 100644
--- a/drivers/hid/hid-prodikeys.c
+++ b/drivers/hid/hid-prodikeys.c
@@ -516,7 +516,7 @@ static void pcmidi_setup_extra_keys(
516 MY PICTURES => KEY_WORDPROCESSOR 516 MY PICTURES => KEY_WORDPROCESSOR
517 MY MUSIC=> KEY_SPREADSHEET 517 MY MUSIC=> KEY_SPREADSHEET
518 */ 518 */
519 unsigned int keys[] = { 519 static const unsigned int keys[] = {
520 KEY_FN, 520 KEY_FN,
521 KEY_MESSENGER, KEY_CALENDAR, 521 KEY_MESSENGER, KEY_CALENDAR,
522 KEY_ADDRESSBOOK, KEY_DOCUMENTS, 522 KEY_ADDRESSBOOK, KEY_DOCUMENTS,
@@ -532,7 +532,7 @@ static void pcmidi_setup_extra_keys(
532 0 532 0
533 }; 533 };
534 534
535 unsigned int *pkeys = &keys[0]; 535 const unsigned int *pkeys = &keys[0];
536 unsigned short i; 536 unsigned short i;
537 537
538 if (pm->ifnum != 1) /* only set up ONCE for interace 1 */ 538 if (pm->ifnum != 1) /* only set up ONCE for interace 1 */