diff options
author | Benjamin Tissoires <benjamin.tissoires@redhat.com> | 2018-04-24 04:04:33 -0400 |
---|---|---|
committer | Jiri Kosina <jkosina@suse.cz> | 2018-04-26 08:17:31 -0400 |
commit | f07b3c1da92db108662f99417a212fc1eddc44d1 (patch) | |
tree | d4ad0e580dfab744d34460c80a361e78c7ff47dd /drivers/hid/hid-magicmouse.c | |
parent | e1b63c0148a7f8edf1691770ec0527fe86fb6ab8 (diff) |
HID: generic: create one input report per application type
It is not a good idea to try to fit all types of applications in the
same input report. There are a lot of devices that are needing
the quirk HID_MULTI_INPUT but this quirk doesn't match the actual HID
description as it is based on the report ID.
Given that most devices with MULTI_INPUT I can think of split nicely
the devices inputs into application, it is a good thing to split the
devices by default based on this assumption.
Also make hid-multitouch following this rule, to not have to deal
with too many input created.
While we are at it, fix some checkpatch complaints about converting
'unsigned' to 'unsigned int'.
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid/hid-magicmouse.c')
-rw-r--r-- | drivers/hid/hid-magicmouse.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/hid/hid-magicmouse.c b/drivers/hid/hid-magicmouse.c index 42ed887ba0be..b454c4386157 100644 --- a/drivers/hid/hid-magicmouse.c +++ b/drivers/hid/hid-magicmouse.c | |||
@@ -531,12 +531,12 @@ static int magicmouse_probe(struct hid_device *hdev, | |||
531 | 531 | ||
532 | if (id->product == USB_DEVICE_ID_APPLE_MAGICMOUSE) | 532 | if (id->product == USB_DEVICE_ID_APPLE_MAGICMOUSE) |
533 | report = hid_register_report(hdev, HID_INPUT_REPORT, | 533 | report = hid_register_report(hdev, HID_INPUT_REPORT, |
534 | MOUSE_REPORT_ID); | 534 | MOUSE_REPORT_ID, 0); |
535 | else { /* USB_DEVICE_ID_APPLE_MAGICTRACKPAD */ | 535 | else { /* USB_DEVICE_ID_APPLE_MAGICTRACKPAD */ |
536 | report = hid_register_report(hdev, HID_INPUT_REPORT, | 536 | report = hid_register_report(hdev, HID_INPUT_REPORT, |
537 | TRACKPAD_REPORT_ID); | 537 | TRACKPAD_REPORT_ID, 0); |
538 | report = hid_register_report(hdev, HID_INPUT_REPORT, | 538 | report = hid_register_report(hdev, HID_INPUT_REPORT, |
539 | DOUBLE_REPORT_ID); | 539 | DOUBLE_REPORT_ID, 0); |
540 | } | 540 | } |
541 | 541 | ||
542 | if (!report) { | 542 | if (!report) { |