diff options
author | David S. Miller <davem@davemloft.net> | 2019-08-27 17:23:31 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2019-08-27 17:23:31 -0400 |
commit | 68aaf4459556b1f9370c259fd486aecad2257552 (patch) | |
tree | 99d92536a3263634969be6b70a96facea85a0df1 /drivers/hid/hid-cp2112.c | |
parent | d00ee466a07eb9182ad3caf6140c7ebb527b4c64 (diff) | |
parent | 9e8312f5e160ade069e131d54ab8652cf0e86e1a (diff) |
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
Minor conflict in r8169, bug fix had two versions in net
and net-next, take the net-next hunks.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/hid/hid-cp2112.c')
-rw-r--r-- | drivers/hid/hid-cp2112.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/hid/hid-cp2112.c b/drivers/hid/hid-cp2112.c index 2310c96ccf4a..db1b55df0d13 100644 --- a/drivers/hid/hid-cp2112.c +++ b/drivers/hid/hid-cp2112.c | |||
@@ -1153,8 +1153,6 @@ static unsigned int cp2112_gpio_irq_startup(struct irq_data *d) | |||
1153 | 1153 | ||
1154 | INIT_DELAYED_WORK(&dev->gpio_poll_worker, cp2112_gpio_poll_callback); | 1154 | INIT_DELAYED_WORK(&dev->gpio_poll_worker, cp2112_gpio_poll_callback); |
1155 | 1155 | ||
1156 | cp2112_gpio_direction_input(gc, d->hwirq); | ||
1157 | |||
1158 | if (!dev->gpio_poll) { | 1156 | if (!dev->gpio_poll) { |
1159 | dev->gpio_poll = true; | 1157 | dev->gpio_poll = true; |
1160 | schedule_delayed_work(&dev->gpio_poll_worker, 0); | 1158 | schedule_delayed_work(&dev->gpio_poll_worker, 0); |
@@ -1204,6 +1202,12 @@ static int __maybe_unused cp2112_allocate_irq(struct cp2112_device *dev, | |||
1204 | return PTR_ERR(dev->desc[pin]); | 1202 | return PTR_ERR(dev->desc[pin]); |
1205 | } | 1203 | } |
1206 | 1204 | ||
1205 | ret = cp2112_gpio_direction_input(&dev->gc, pin); | ||
1206 | if (ret < 0) { | ||
1207 | dev_err(dev->gc.parent, "Failed to set GPIO to input dir\n"); | ||
1208 | goto err_desc; | ||
1209 | } | ||
1210 | |||
1207 | ret = gpiochip_lock_as_irq(&dev->gc, pin); | 1211 | ret = gpiochip_lock_as_irq(&dev->gc, pin); |
1208 | if (ret) { | 1212 | if (ret) { |
1209 | dev_err(dev->gc.parent, "Failed to lock GPIO as interrupt\n"); | 1213 | dev_err(dev->gc.parent, "Failed to lock GPIO as interrupt\n"); |