diff options
author | Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com> | 2015-01-30 05:17:23 -0500 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2015-01-30 13:38:43 -0500 |
commit | 0cb09a97d85753a372390bfc04172d980d235f2c (patch) | |
tree | 4a6259d46a814aa552db2d0191903d3e802ec2f0 /drivers/gpu/drm | |
parent | f82107950e9bda3779610e37bdfdccae6fc16f87 (diff) |
drm/i915: Use pipe_config's cpu_transcoder for reading encoder hw state
The get_config() functions for ddi and dp_mst, used to read the value
of cpu_transcoder from the crtc->config instead of the state passed as
an argument. On the hardware state readout path, that happens to work
since the proper value is written to it before encoder->get_config() is
called. However, in the check_crtc() path, the state will be read from
the cpu_transcoder in the software tracking, instead of the one just
read out from hw. Using the field in the supplied intel_crtc_state
should do the right thing in both cases.
v2: Fix intel_ddi_get_config() too. (Ander)
Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Diffstat (limited to 'drivers/gpu/drm')
-rw-r--r-- | drivers/gpu/drm/i915/intel_ddi.c | 2 | ||||
-rw-r--r-- | drivers/gpu/drm/i915/intel_dp_mst.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c index ad8b73d8eaf3..f14e8a2a022d 100644 --- a/drivers/gpu/drm/i915/intel_ddi.c +++ b/drivers/gpu/drm/i915/intel_ddi.c | |||
@@ -2038,7 +2038,7 @@ void intel_ddi_get_config(struct intel_encoder *encoder, | |||
2038 | { | 2038 | { |
2039 | struct drm_i915_private *dev_priv = encoder->base.dev->dev_private; | 2039 | struct drm_i915_private *dev_priv = encoder->base.dev->dev_private; |
2040 | struct intel_crtc *intel_crtc = to_intel_crtc(encoder->base.crtc); | 2040 | struct intel_crtc *intel_crtc = to_intel_crtc(encoder->base.crtc); |
2041 | enum transcoder cpu_transcoder = intel_crtc->config->cpu_transcoder; | 2041 | enum transcoder cpu_transcoder = pipe_config->cpu_transcoder; |
2042 | struct intel_hdmi *intel_hdmi; | 2042 | struct intel_hdmi *intel_hdmi; |
2043 | u32 temp, flags = 0; | 2043 | u32 temp, flags = 0; |
2044 | 2044 | ||
diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c b/drivers/gpu/drm/i915/intel_dp_mst.c index 2856b0bffd07..9f67a379a9a5 100644 --- a/drivers/gpu/drm/i915/intel_dp_mst.c +++ b/drivers/gpu/drm/i915/intel_dp_mst.c | |||
@@ -226,7 +226,7 @@ static void intel_dp_mst_enc_get_config(struct intel_encoder *encoder, | |||
226 | struct intel_crtc *crtc = to_intel_crtc(encoder->base.crtc); | 226 | struct intel_crtc *crtc = to_intel_crtc(encoder->base.crtc); |
227 | struct drm_device *dev = encoder->base.dev; | 227 | struct drm_device *dev = encoder->base.dev; |
228 | struct drm_i915_private *dev_priv = dev->dev_private; | 228 | struct drm_i915_private *dev_priv = dev->dev_private; |
229 | enum transcoder cpu_transcoder = crtc->config->cpu_transcoder; | 229 | enum transcoder cpu_transcoder = pipe_config->cpu_transcoder; |
230 | u32 temp, flags = 0; | 230 | u32 temp, flags = 0; |
231 | 231 | ||
232 | pipe_config->has_dp_encoder = true; | 232 | pipe_config->has_dp_encoder = true; |