summaryrefslogtreecommitdiffstats
path: root/drivers/gpio
diff options
context:
space:
mode:
authorBartosz Golaszewski <bgolaszewski@baylibre.com>2019-03-28 06:38:06 -0400
committerBartosz Golaszewski <bgolaszewski@baylibre.com>2019-03-28 13:04:53 -0400
commitce9fb53c72834646f26ecb2213e40e6876048f87 (patch)
tree495c2e6fcc3c0f681257936101b19479f2ab91d0 /drivers/gpio
parent2583303debb7acc77295b77901916d08a4c743c2 (diff)
gpio: mockup: use simple_read_from_buffer() in debugfs read callback
Calling read() for a single byte read will return 2 currently. Use simple_read_from_buffer() which correctly handles all sizes. Fixes: 2a9e27408e12 ("gpio: mockup: rework debugfs interface") Reviewed-by: Mukesh Ojha <mojha@codeaurora.org> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Diffstat (limited to 'drivers/gpio')
-rw-r--r--drivers/gpio/gpio-mockup.c10
1 files changed, 2 insertions, 8 deletions
diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c
index 74ba8b1d71d8..b6a4efce7c92 100644
--- a/drivers/gpio/gpio-mockup.c
+++ b/drivers/gpio/gpio-mockup.c
@@ -204,10 +204,9 @@ static ssize_t gpio_mockup_debugfs_read(struct file *file,
204 struct gpio_mockup_chip *chip; 204 struct gpio_mockup_chip *chip;
205 struct seq_file *sfile; 205 struct seq_file *sfile;
206 struct gpio_chip *gc; 206 struct gpio_chip *gc;
207 int val, rv, cnt; 207 int val, cnt;
208 char buf[3]; 208 char buf[3];
209 209
210
211 if (*ppos != 0) 210 if (*ppos != 0)
212 return 0; 211 return 0;
213 212
@@ -219,12 +218,7 @@ static ssize_t gpio_mockup_debugfs_read(struct file *file,
219 val = gpio_mockup_get(gc, priv->offset); 218 val = gpio_mockup_get(gc, priv->offset);
220 cnt = snprintf(buf, sizeof(buf), "%d\n", val); 219 cnt = snprintf(buf, sizeof(buf), "%d\n", val);
221 220
222 rv = copy_to_user(usr_buf, buf, cnt); 221 return simple_read_from_buffer(usr_buf, size, ppos, buf, cnt);
223 if (rv)
224 return rv;
225
226 *ppos += cnt;
227 return cnt;
228} 222}
229 223
230static ssize_t gpio_mockup_debugfs_write(struct file *file, 224static ssize_t gpio_mockup_debugfs_write(struct file *file,