summaryrefslogtreecommitdiffstats
path: root/drivers/gpio/gpio-pch.c
diff options
context:
space:
mode:
authorLinus Walleij <linus.walleij@linaro.org>2015-12-21 05:34:11 -0500
committerLinus Walleij <linus.walleij@linaro.org>2015-12-26 16:28:20 -0500
commit5b818fd18c7b81bb41c8a18943e562407ac95952 (patch)
tree89179e946d1bffd89811e361d2308ce8daf557d8 /drivers/gpio/gpio-pch.c
parent40f805806dfb761650080ee008aeb96c012a0e03 (diff)
gpio: pch: Be sure to clamp return value
As we want gpio_chip .get() calls to be able to return negative error codes and propagate to drivers, we need to go over all drivers and make sure their return values are clamped to [0,1]. We do this by using the ret = !!(val) design pattern. Cc: Thierry Reding <treding@nvidia.com> Cc: Daniel Krueger <daniel.krueger@systec-electronic.com> Cc: Jean Delvare <jdelvare@suse.de> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/gpio/gpio-pch.c')
-rw-r--r--drivers/gpio/gpio-pch.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c
index af0715f8524b..8c45b74dcf21 100644
--- a/drivers/gpio/gpio-pch.c
+++ b/drivers/gpio/gpio-pch.c
@@ -127,7 +127,7 @@ static int pch_gpio_get(struct gpio_chip *gpio, unsigned nr)
127{ 127{
128 struct pch_gpio *chip = container_of(gpio, struct pch_gpio, gpio); 128 struct pch_gpio *chip = container_of(gpio, struct pch_gpio, gpio);
129 129
130 return ioread32(&chip->reg->pi) & (1 << nr); 130 return !!(ioread32(&chip->reg->pi) & (1 << nr));
131} 131}
132 132
133static int pch_gpio_direction_output(struct gpio_chip *gpio, unsigned nr, 133static int pch_gpio_direction_output(struct gpio_chip *gpio, unsigned nr,