Merge tag 'char-misc-4.21-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc

Pull char/misc driver updates from Greg KH:
 "Here is the big set of char and misc driver patches for 4.21-rc1.

  Lots of different types of driver things in here, as this tree seems
  to be the "collection of various driver subsystems not big enough to
  have their own git tree" lately.

  Anyway, some highlights of the changes in here:

   - binderfs: is it a rule that all driver subsystems will eventually
     grow to have their own filesystem? Binder now has one to handle the
     use of it in containerized systems.

     This was discussed at the Plumbers conference a few months ago and
     knocked into mergable shape very fast by Christian Brauner. Who
     also has signed up to be another binder maintainer, showing a
     distinct lack of good judgement :)

   - binder updates and fixes

   - mei driver updates

   - fpga driver updates and additions

   - thunderbolt driver updates

   - soundwire driver updates

   - extcon driver updates

   - nvmem driver updates

   - hyper-v driver updates

   - coresight driver updates

   - pvpanic driver additions and reworking for more device support

   - lp driver updates. Yes really, it's _finally_ moved to the proper
     parallal port driver model, something I never thought I would see
     happen. Good stuff.

   - other tiny driver updates and fixes.

  All of these have been in linux-next for a while with no reported
  issues"

* tag 'char-misc-4.21-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc: (116 commits)
  MAINTAINERS: add another Android binder maintainer
  intel_th: msu: Fix an off-by-one in attribute store
  stm class: Add a reference to the SyS-T document
  stm class: Fix a module refcount leak in policy creation error path
  char: lp: use new parport device model
  char: lp: properly count the lp devices
  char: lp: use first unused lp number while registering
  char: lp: detach the device when parallel port is removed
  char: lp: introduce list to save port number
  bus: qcom: remove duplicated include from qcom-ebi2.c
  VMCI: Use memdup_user() rather than duplicating its implementation
  char/rtc: Use of_node_name_eq for node name comparisons
  misc: mic: fix a DMA pool free failure
  ptp: fix an IS_ERR() vs NULL check
  genwqe: Fix size check
  binder: implement binderfs
  binder: fix use-after-free due to ksys_close() during fdget()
  bus: fsl-mc: remove duplicated include files
  bus: fsl-mc: explicitly define the fsl_mc_command endianness
  misc: ti-st: make array read_ver_cmd static, shrinks object size
  ...

1 files changed, 37 insertions, 12 deletions

diff --git a/drivers/fpga/altera-cvp.c b/drivers/fpga/altera-cvp.c
index 610a1558e0ed..35c3aa5792e2 100644
--- a/drivers/fpga/altera-cvp.c
+++ b/drivers/fpga/altera-cvp.c
@@ -403,6 +403,7 @@ static int altera_cvp_probe(struct pci_dev *pdev,
         struct altera_cvp_conf *conf;
         struct fpga_manager *mgr;
         u16 cmd, val;
+        u32 regval;
         int ret;
 
         /*
@@ -416,6 +417,14 @@ static int altera_cvp_probe(struct pci_dev *pdev,
                 return -ENODEV;
         }
 
+        pci_read_config_dword(pdev, VSE_CVP_STATUS, &regval);
+        if (!(regval & VSE_CVP_STATUS_CVP_EN)) {
+                dev_err(&pdev->dev,
+                        "CVP is disabled for this device: CVP_STATUS Reg 0x%x\n",
+                        regval);
+                return -ENODEV;
+        }
+
         conf = devm_kzalloc(&pdev->dev, sizeof(*conf), GFP_KERNEL);
         if (!conf)
                 return -ENOMEM;
@@ -466,18 +475,11 @@ static int altera_cvp_probe(struct pci_dev *pdev,
         if (ret)
                 goto err_unmap;
 
-        ret = driver_create_file(&altera_cvp_driver.driver,
-                                 &driver_attr_chkcfg);
-        if (ret) {
-                dev_err(&pdev->dev, "Can't create sysfs chkcfg file\n");
-                fpga_mgr_unregister(mgr);
-                goto err_unmap;
-        }
-
         return 0;
 
 err_unmap:
-        pci_iounmap(pdev, conf->map);
+        if (conf->map)
+                pci_iounmap(pdev, conf->map);
         pci_release_region(pdev, CVP_BAR);
 err_disable:
         cmd &= ~PCI_COMMAND_MEMORY;
@@ -491,16 +493,39 @@ static void altera_cvp_remove(struct pci_dev *pdev)
         struct altera_cvp_conf *conf = mgr->priv;
         u16 cmd;
 
-        driver_remove_file(&altera_cvp_driver.driver, &driver_attr_chkcfg);
         fpga_mgr_unregister(mgr);
-        pci_iounmap(pdev, conf->map);
+        if (conf->map)
+                pci_iounmap(pdev, conf->map);
         pci_release_region(pdev, CVP_BAR);
         pci_read_config_word(pdev, PCI_COMMAND, &cmd);
         cmd &= ~PCI_COMMAND_MEMORY;
         pci_write_config_word(pdev, PCI_COMMAND, cmd);
 }
 
-module_pci_driver(altera_cvp_driver);
+static int __init altera_cvp_init(void)
+{
+        int ret;
+
+        ret = pci_register_driver(&altera_cvp_driver);
+        if (ret)
+                return ret;
+
+        ret = driver_create_file(&altera_cvp_driver.driver,
+                                 &driver_attr_chkcfg);
+        if (ret)
+                pr_warn("Can't create sysfs chkcfg file\n");
+
+        return 0;
+}
+
+static void __exit altera_cvp_exit(void)
+{
+        driver_remove_file(&altera_cvp_driver.driver, &driver_attr_chkcfg);
+        pci_unregister_driver(&altera_cvp_driver);
+}
+
+module_init(altera_cvp_init);
+module_exit(altera_cvp_exit);
 
 MODULE_LICENSE("GPL v2");
 MODULE_AUTHOR("Anatolij Gustschin <agust@denx.de>");