diff options
author | Yijing Wang <wangyijing@huawei.com> | 2014-05-29 23:01:03 -0400 |
---|---|---|
committer | Bjorn Helgaas <bhelgaas@google.com> | 2014-05-30 11:34:27 -0400 |
commit | c893d133eaccdda2516a3e71cd05a7dac2e14b00 (patch) | |
tree | 2f296b5a88e4e794fb48d4c22c8108ce6f671bbc /drivers/edac | |
parent | d97ffe236894856d08146390ef3fbe6448a8ac2b (diff) |
PCI: Make pci_bus_add_device() void
pci_bus_add_device() always returns 0, so there's no point in returning
anything at all. Make it a void function and remove the tests of the
return value from the callers.
[bhelgaas: changelog, remove unused "err" from i82875p_setup_overfl_dev()]
Signed-off-by: Yijing Wang <wangyijing@huawei.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Diffstat (limited to 'drivers/edac')
-rw-r--r-- | drivers/edac/i82875p_edac.c | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/drivers/edac/i82875p_edac.c b/drivers/edac/i82875p_edac.c index 8d0450b9b9af..4009077c8839 100644 --- a/drivers/edac/i82875p_edac.c +++ b/drivers/edac/i82875p_edac.c | |||
@@ -275,7 +275,6 @@ static int i82875p_setup_overfl_dev(struct pci_dev *pdev, | |||
275 | { | 275 | { |
276 | struct pci_dev *dev; | 276 | struct pci_dev *dev; |
277 | void __iomem *window; | 277 | void __iomem *window; |
278 | int err; | ||
279 | 278 | ||
280 | *ovrfl_pdev = NULL; | 279 | *ovrfl_pdev = NULL; |
281 | *ovrfl_window = NULL; | 280 | *ovrfl_window = NULL; |
@@ -293,12 +292,7 @@ static int i82875p_setup_overfl_dev(struct pci_dev *pdev, | |||
293 | if (dev == NULL) | 292 | if (dev == NULL) |
294 | return 1; | 293 | return 1; |
295 | 294 | ||
296 | err = pci_bus_add_device(dev); | 295 | pci_bus_add_device(dev); |
297 | if (err) { | ||
298 | i82875p_printk(KERN_ERR, | ||
299 | "%s(): pci_bus_add_device() Failed\n", | ||
300 | __func__); | ||
301 | } | ||
302 | pci_bus_assign_resources(dev->bus); | 296 | pci_bus_assign_resources(dev->bus); |
303 | } | 297 | } |
304 | 298 | ||