summaryrefslogtreecommitdiffstats
path: root/drivers/dma
diff options
context:
space:
mode:
authorMaxime Ripard <maxime.ripard@free-electrons.com>2014-10-16 05:01:01 -0400
committerVinod Koul <vinod.koul@intel.com>2014-11-06 01:03:07 -0500
commit1e916474a98eced0c2fd7dfeb13636ddf1e20348 (patch)
tree764136d1c23a174d94a6fcd96ae1d3a5698f5567 /drivers/dma
parent9aa7171157ef452517056e1368459d6f5b4636aa (diff)
dmaengine: sh: Remove chancnt affectations
chanctnt is already filled by dma_async_device_register, which uses the channel list to know how much channels there is. Since it's already filled, we can safely remove it from the drivers' probe function. Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'drivers/dma')
-rw-r--r--drivers/dma/sh/rcar-audmapp.c2
-rw-r--r--drivers/dma/sh/rcar-hpbdma.c2
-rw-r--r--drivers/dma/sh/shdma-base.c2
-rw-r--r--drivers/dma/sh/shdmac.c2
-rw-r--r--drivers/dma/sh/sudmac.c2
5 files changed, 1 insertions, 9 deletions
diff --git a/drivers/dma/sh/rcar-audmapp.c b/drivers/dma/sh/rcar-audmapp.c
index 80fd2aeb4870..3db6be7d7c28 100644
--- a/drivers/dma/sh/rcar-audmapp.c
+++ b/drivers/dma/sh/rcar-audmapp.c
@@ -253,7 +253,6 @@ static int audmapp_chan_probe(struct platform_device *pdev,
253 253
254static void audmapp_chan_remove(struct audmapp_device *audev) 254static void audmapp_chan_remove(struct audmapp_device *audev)
255{ 255{
256 struct dma_device *dma_dev = &audev->shdma_dev.dma_dev;
257 struct shdma_chan *schan; 256 struct shdma_chan *schan;
258 int i; 257 int i;
259 258
@@ -261,7 +260,6 @@ static void audmapp_chan_remove(struct audmapp_device *audev)
261 BUG_ON(!schan); 260 BUG_ON(!schan);
262 shdma_chan_remove(schan); 261 shdma_chan_remove(schan);
263 } 262 }
264 dma_dev->chancnt = 0;
265} 263}
266 264
267static struct dma_chan *audmapp_of_xlate(struct of_phandle_args *dma_spec, 265static struct dma_chan *audmapp_of_xlate(struct of_phandle_args *dma_spec,
diff --git a/drivers/dma/sh/rcar-hpbdma.c b/drivers/dma/sh/rcar-hpbdma.c
index b212d9471ab5..5ab921865ffe 100644
--- a/drivers/dma/sh/rcar-hpbdma.c
+++ b/drivers/dma/sh/rcar-hpbdma.c
@@ -619,7 +619,6 @@ error:
619 619
620static void hpb_dmae_chan_remove(struct hpb_dmae_device *hpbdev) 620static void hpb_dmae_chan_remove(struct hpb_dmae_device *hpbdev)
621{ 621{
622 struct dma_device *dma_dev = &hpbdev->shdma_dev.dma_dev;
623 struct shdma_chan *schan; 622 struct shdma_chan *schan;
624 int i; 623 int i;
625 624
@@ -628,7 +627,6 @@ static void hpb_dmae_chan_remove(struct hpb_dmae_device *hpbdev)
628 627
629 shdma_chan_remove(schan); 628 shdma_chan_remove(schan);
630 } 629 }
631 dma_dev->chancnt = 0;
632} 630}
633 631
634static int hpb_dmae_remove(struct platform_device *pdev) 632static int hpb_dmae_remove(struct platform_device *pdev)
diff --git a/drivers/dma/sh/shdma-base.c b/drivers/dma/sh/shdma-base.c
index 42d497416196..ed5b0993edfa 100644
--- a/drivers/dma/sh/shdma-base.c
+++ b/drivers/dma/sh/shdma-base.c
@@ -951,7 +951,7 @@ void shdma_chan_probe(struct shdma_dev *sdev,
951 /* Add the channel to DMA device channel list */ 951 /* Add the channel to DMA device channel list */
952 list_add_tail(&schan->dma_chan.device_node, 952 list_add_tail(&schan->dma_chan.device_node,
953 &sdev->dma_dev.channels); 953 &sdev->dma_dev.channels);
954 sdev->schan[sdev->dma_dev.chancnt++] = schan; 954 sdev->schan[id] = schan;
955} 955}
956EXPORT_SYMBOL(shdma_chan_probe); 956EXPORT_SYMBOL(shdma_chan_probe);
957 957
diff --git a/drivers/dma/sh/shdmac.c b/drivers/dma/sh/shdmac.c
index 58eb85770eba..b65317c6ea4e 100644
--- a/drivers/dma/sh/shdmac.c
+++ b/drivers/dma/sh/shdmac.c
@@ -572,7 +572,6 @@ err_no_irq:
572 572
573static void sh_dmae_chan_remove(struct sh_dmae_device *shdev) 573static void sh_dmae_chan_remove(struct sh_dmae_device *shdev)
574{ 574{
575 struct dma_device *dma_dev = &shdev->shdma_dev.dma_dev;
576 struct shdma_chan *schan; 575 struct shdma_chan *schan;
577 int i; 576 int i;
578 577
@@ -581,7 +580,6 @@ static void sh_dmae_chan_remove(struct sh_dmae_device *shdev)
581 580
582 shdma_chan_remove(schan); 581 shdma_chan_remove(schan);
583 } 582 }
584 dma_dev->chancnt = 0;
585} 583}
586 584
587static void sh_dmae_shutdown(struct platform_device *pdev) 585static void sh_dmae_shutdown(struct platform_device *pdev)
diff --git a/drivers/dma/sh/sudmac.c b/drivers/dma/sh/sudmac.c
index 3ce103909896..69a5c7b87ee0 100644
--- a/drivers/dma/sh/sudmac.c
+++ b/drivers/dma/sh/sudmac.c
@@ -295,7 +295,6 @@ err_no_irq:
295 295
296static void sudmac_chan_remove(struct sudmac_device *su_dev) 296static void sudmac_chan_remove(struct sudmac_device *su_dev)
297{ 297{
298 struct dma_device *dma_dev = &su_dev->shdma_dev.dma_dev;
299 struct shdma_chan *schan; 298 struct shdma_chan *schan;
300 int i; 299 int i;
301 300
@@ -304,7 +303,6 @@ static void sudmac_chan_remove(struct sudmac_device *su_dev)
304 303
305 shdma_chan_remove(schan); 304 shdma_chan_remove(schan);
306 } 305 }
307 dma_dev->chancnt = 0;
308} 306}
309 307
310static dma_addr_t sudmac_slave_addr(struct shdma_chan *schan) 308static dma_addr_t sudmac_slave_addr(struct shdma_chan *schan)