diff options
author | Luis Chamberlain <mcgrof@kernel.org> | 2019-01-04 03:23:09 -0500 |
---|---|---|
committer | Christoph Hellwig <hch@lst.de> | 2019-01-08 07:58:37 -0500 |
commit | 750afb08ca71310fcf0c4e2cb1565c63b8235b60 (patch) | |
tree | 1dde3877eb4a1a0f0349786b66c3d9276ae94561 /drivers/dma/xilinx | |
parent | 3bd6e94bec122a951d462c239b47954cf5f36e33 (diff) |
cross-tree: phase out dma_zalloc_coherent()
We already need to zero out memory for dma_alloc_coherent(), as such
using dma_zalloc_coherent() is superflous. Phase it out.
This change was generated with the following Coccinelle SmPL patch:
@ replace_dma_zalloc_coherent @
expression dev, size, data, handle, flags;
@@
-dma_zalloc_coherent(dev, size, handle, flags)
+dma_alloc_coherent(dev, size, handle, flags)
Suggested-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
[hch: re-ran the script on the latest tree]
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/dma/xilinx')
-rw-r--r-- | drivers/dma/xilinx/xilinx_dma.c | 14 | ||||
-rw-r--r-- | drivers/dma/xilinx/zynqmp_dma.c | 6 |
2 files changed, 10 insertions, 10 deletions
diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c index 02880963092f..cb20b411493e 100644 --- a/drivers/dma/xilinx/xilinx_dma.c +++ b/drivers/dma/xilinx/xilinx_dma.c | |||
@@ -879,10 +879,9 @@ static int xilinx_dma_alloc_chan_resources(struct dma_chan *dchan) | |||
879 | */ | 879 | */ |
880 | if (chan->xdev->dma_config->dmatype == XDMA_TYPE_AXIDMA) { | 880 | if (chan->xdev->dma_config->dmatype == XDMA_TYPE_AXIDMA) { |
881 | /* Allocate the buffer descriptors. */ | 881 | /* Allocate the buffer descriptors. */ |
882 | chan->seg_v = dma_zalloc_coherent(chan->dev, | 882 | chan->seg_v = dma_alloc_coherent(chan->dev, |
883 | sizeof(*chan->seg_v) * | 883 | sizeof(*chan->seg_v) * XILINX_DMA_NUM_DESCS, |
884 | XILINX_DMA_NUM_DESCS, | 884 | &chan->seg_p, GFP_KERNEL); |
885 | &chan->seg_p, GFP_KERNEL); | ||
886 | if (!chan->seg_v) { | 885 | if (!chan->seg_v) { |
887 | dev_err(chan->dev, | 886 | dev_err(chan->dev, |
888 | "unable to allocate channel %d descriptors\n", | 887 | "unable to allocate channel %d descriptors\n", |
@@ -895,9 +894,10 @@ static int xilinx_dma_alloc_chan_resources(struct dma_chan *dchan) | |||
895 | * so allocating a desc segment during channel allocation for | 894 | * so allocating a desc segment during channel allocation for |
896 | * programming tail descriptor. | 895 | * programming tail descriptor. |
897 | */ | 896 | */ |
898 | chan->cyclic_seg_v = dma_zalloc_coherent(chan->dev, | 897 | chan->cyclic_seg_v = dma_alloc_coherent(chan->dev, |
899 | sizeof(*chan->cyclic_seg_v), | 898 | sizeof(*chan->cyclic_seg_v), |
900 | &chan->cyclic_seg_p, GFP_KERNEL); | 899 | &chan->cyclic_seg_p, |
900 | GFP_KERNEL); | ||
901 | if (!chan->cyclic_seg_v) { | 901 | if (!chan->cyclic_seg_v) { |
902 | dev_err(chan->dev, | 902 | dev_err(chan->dev, |
903 | "unable to allocate desc segment for cyclic DMA\n"); | 903 | "unable to allocate desc segment for cyclic DMA\n"); |
diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dma.c index 8db51750ce93..4478787a247f 100644 --- a/drivers/dma/xilinx/zynqmp_dma.c +++ b/drivers/dma/xilinx/zynqmp_dma.c | |||
@@ -490,9 +490,9 @@ static int zynqmp_dma_alloc_chan_resources(struct dma_chan *dchan) | |||
490 | list_add_tail(&desc->node, &chan->free_list); | 490 | list_add_tail(&desc->node, &chan->free_list); |
491 | } | 491 | } |
492 | 492 | ||
493 | chan->desc_pool_v = dma_zalloc_coherent(chan->dev, | 493 | chan->desc_pool_v = dma_alloc_coherent(chan->dev, |
494 | (2 * chan->desc_size * ZYNQMP_DMA_NUM_DESCS), | 494 | (2 * chan->desc_size * ZYNQMP_DMA_NUM_DESCS), |
495 | &chan->desc_pool_p, GFP_KERNEL); | 495 | &chan->desc_pool_p, GFP_KERNEL); |
496 | if (!chan->desc_pool_v) | 496 | if (!chan->desc_pool_v) |
497 | return -ENOMEM; | 497 | return -ENOMEM; |
498 | 498 | ||