diff options
author | Matthias Reichl <hias@horus.com> | 2017-02-20 14:01:16 -0500 |
---|---|---|
committer | Vinod Koul <vinod.koul@intel.com> | 2017-03-05 22:19:11 -0500 |
commit | 2201ac6129fa162ac24da089a034bb0971648ebb (patch) | |
tree | 8be9bbc08e1a13278e20901442bc3e8a1366af2d /drivers/dma/bcm2835-dma.c | |
parent | c1ae3cfa0e89fa1a7ecc4c99031f5e9ae99d9201 (diff) |
dmaengine: bcm2835: Fix cyclic DMA period splitting
The code responsible for splitting periods into chunks that
can be handled by the DMA controller missed to update total_len,
the number of bytes processed in the current period, when there
are more chunks to follow.
Therefore total_len was stuck at 0 and the code didn't work at all.
This resulted in a wrong control block layout and audio issues because
the cyclic DMA callback wasn't executing on period boundaries.
Fix this by adding the missing total_len update.
Signed-off-by: Matthias Reichl <hias@horus.com>
Signed-off-by: Martin Sperl <kernel@martin.sperl.org>
Tested-by: Clive Messer <clive.messer@digitaldreamtime.co.uk>
Reviewed-by: Eric Anholt <eric@anholt.net>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'drivers/dma/bcm2835-dma.c')
-rw-r--r-- | drivers/dma/bcm2835-dma.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c index e18dc596cf24..6204cc32d09c 100644 --- a/drivers/dma/bcm2835-dma.c +++ b/drivers/dma/bcm2835-dma.c | |||
@@ -251,8 +251,11 @@ static void bcm2835_dma_create_cb_set_length( | |||
251 | */ | 251 | */ |
252 | 252 | ||
253 | /* have we filled in period_length yet? */ | 253 | /* have we filled in period_length yet? */ |
254 | if (*total_len + control_block->length < period_len) | 254 | if (*total_len + control_block->length < period_len) { |
255 | /* update number of bytes in this period so far */ | ||
256 | *total_len += control_block->length; | ||
255 | return; | 257 | return; |
258 | } | ||
256 | 259 | ||
257 | /* calculate the length that remains to reach period_length */ | 260 | /* calculate the length that remains to reach period_length */ |
258 | control_block->length = period_len - *total_len; | 261 | control_block->length = period_len - *total_len; |